-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AutoClone.md #328
Merged
+5
−5
Merged
Update AutoClone.md #328
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,28 +82,28 @@ cache.SetupSerializer(new FusionCacheSystemTextJsonSerializer()); | |
|
||
cache.Set("foo", new Person { Name = "John" }); | ||
|
||
// THIS WILL GET A CLONE | ||
// RETURNS A CLONE OF THE CACHED INSTANCE | ||
var person1 = cache.GetOrDefault<Person>("foo", options => options.SetAutoClone(true)); | ||
Console.WriteLine($"person1: {person1.Name}"); | ||
Console.WriteLine(); | ||
|
||
// THIS WILL GET A CLONE, AND CHANGE (ONLY) IT | ||
// RETURNS A CLONE OF THE CACHED INSTANCE: CHANGES APPLIED ONLY THE CLONE, CACHED INSTANCE REMAINS UNCHANGED | ||
var person2 = cache.GetOrDefault<Person>("foo", options => options.SetAutoClone(true)); | ||
person2.Name = "Jane"; | ||
Console.WriteLine($"person1: {person1.Name}"); | ||
Console.WriteLine($"person2: {person2.Name}"); | ||
Console.WriteLine(); | ||
|
||
// THIS WILL GET THE INSTANCE IN THE CACHE, AND CHANGE IT | ||
// RETURNS DIRECT REFERENCE TO THE CACHED INSTANCE: CHANGES APPLIED TO THE CACHED INSTANCE ITSELF | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as the comment above. Also, it's missing the verb "are" in "Changes are applied to", which makes it verbose. 🤷 |
||
var person3 = cache.GetOrDefault<Person>("foo"); | ||
person3.Name = "Jim"; | ||
Console.WriteLine($"person1: {person1.Name}"); | ||
Console.WriteLine($"person2: {person2.Name}"); | ||
Console.WriteLine($"person3: {person3.Name}"); | ||
Console.WriteLine(); | ||
|
||
// THIS WILL GET THE INSTANCE IN THE CACHE AGAIN, AND CHANGE IT | ||
// SO, BOTH person3 AND person4 WILL HAVE THE SAME REFERENCE | ||
// RETURNS DIRECT REFERENCE TO THE CACHED INSTANCE: THE INSTANCE IS THE SAME AS BEFORE | ||
// CHANGES APPLIED TO BOTH person3 AND person4 AS THEY POINT TO THE SAME CACHED INSTANCE | ||
var person4 = cache.GetOrDefault<Person>("foo"); | ||
person4.Name = "Joe"; | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a couple of points regarding this comment:
(MODIFICATIONS AFFECT ONLY THE CLONE)
would be ideal. However, this version could also work:// RETURNS A CLONED INSTANCE OF THE CACHED OBJECT: CHANGES ARE APPLIED ONLY TO THE CLONED INSTANCE, LEAVING THE CACHED INSTANCE UNMODIFIED