-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the Serializer benchmarks #343
Merged
jodydonetti
merged 4 commits into
ZiggyCreatures:main
from
stebet:serializer-benchmark-improvements
Dec 13, 2024
Merged
Improving the Serializer benchmarks #343
jodydonetti
merged 4 commits into
ZiggyCreatures:main
from
stebet:serializer-benchmark-improvements
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cleaning up the code and config for it. Also added tests for serializing arrays to check for memory pressure on buffers.
Example Output for the Serializer Benchmarks after these changes:
|
jodydonetti
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stebet
added a commit
to stebet/FusionCache
that referenced
this pull request
Dec 18, 2024
* Improving the Serializer benchmark by adding all the serializers and cleaning up the code and config for it. Also added tests for serializing arrays to check for memory pressure on buffers. * Reverting NuGet updates * Fixing Job config * Minor usings cleanup --------- Co-authored-by: Jody Donetti <[email protected]> Co-authored-by: Stefán Jökull Sigurðarson <[email protected]>
jodydonetti
added a commit
that referenced
this pull request
Dec 18, 2024
Improving the Serializer benchmarks (#343) * Improving the Serializer benchmark by adding all the serializers and cleaning up the code and config for it. Also added tests for serializing arrays to check for memory pressure on buffers. * Fixing Job config * Minor usings cleanup --------- Co-authored-by: Jody Donetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToString()
on the Serializer implementations for better reporting in BenchmarkDotNet to display the type names depending on if they are using RecyclableMemoryStreams or not.