-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gas charges related to source file and input JSONs #1036
base: master
Are you sure you want to change the base?
Conversation
The blockchain runs the checker prior to running the interpreter during a deployment. Since this check must be done at the earliest, move it to the checker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something doesn't look right.
I would expect all init output files to have a different gas_remaining with this PR. 31 files of the form init_*.json
are changed in this PR, but we appear to have 87 of them in our testsuite:
cnn@tautology:~/Projects/scilla$ ls -la tests/runner/*/init_*.json | wc -l
87
You are looking for |
I'm clearly not on top of my game. :-( It looks fine, then. |
@vaivaswatha : Status on this? |
I can't merge this till Zilliqa/Zilliqa#2678 is done. |
These charges, to make it uniform with compiled Scilla, will be charged at the blockchain layer, so we must remove it here from Scilla.
Zilliqa/Zilliqa#2678