Correct log index returns in etherium apis #2283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxconway
force-pushed
the
max/bugfix/correct_eth_log_indices
branch
from
72bc4dd to
3b54398
Compare
|
Bencher Report| Branch | max/bugfix/correct_eth_log_indices |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,036.30(-14.04%)Baseline: 1,205.63 | 1,595.45 (64.95%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 445.82(-6.52%)Baseline: 476.89 | 676.68 (65.88%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 4,102.10(+3.92%)Baseline: 3,947.38 | 5,177.91 (79.22%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 10.22(+11.21%)Baseline: 9.19 | 11.58 (88.23%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes log index returns
Logs need to be indexed starting at 0 at the start of each block (versus previously they started at 0 for each receipt)
This commit does it all on the fly, counting through blocks as needed at the point of returning from the APIs, rather than by adding to the log structures. This keeps the logs themselves cleaner but at the cost of some messy code and some amount of performance penalty.
Closes #2188