Store ZQ1 blocks during sync #2287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | 2232-store-zq1-blocks |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 1,034.40 (-16.63%) | 1,634.99 (63.27%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 445.77 (-10.96%) | 719.26 (61.98%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 4,147.10 (+5.45%) | 5,142.99 (80.64%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 10.39 (+14.20%) | 11.43 (90.95%) |
shawn-zil
requested review from
JamesHinshelwood,
bzawisto and
DrZoltanFazekas
shawn-zil
force-pushed
the
2232-store-zq1-blocks
branch
from
a8c48a8 to
49ae741
Compare
bzawisto
reviewed
Feb 4, 2025
shawn-zil
force-pushed
the
2232-store-zq1-blocks
branch
from
49ae741 to
c51a58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change that just writes the block to the database, without execution, if it contains any ZQ1 transactions.
This PR is dependent on #2054 and should use the same check.