fix kstring new vs free

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: vcfppR
 Title: Rapid Manipulation of the Variant Call Format (VCF)
-Version: 0.4.3
+Version: 0.4.4
 Authors@R: c(
     person("Zilong", "Li", , "[email protected]", role = c("aut", "cre"),
            comment = c(ORCID = "0000-0001-5859-2078")),

cleanup.win

@@ -1,4 +1,5 @@
 #!/bin/sh
 
-rm -f src/htslib-1.18/config.h src/*.o src/*.so src/*.dll src/*.dylib 
-cd src/htslib-1.18/ && make clean && cd -
+HTSLIB_DIR=htslib-1.19.1
+rm -f src/${HTSLIB_DIR}/config.h src/*.o src/*.so src/*.dll src/*.dylib 
+cd src/${HTSLIB_DIR}/ && make clean && cd -

src/Makevars.win

@@ -1,4 +1,4 @@
-HTSLIB_DIR=htslib-1.18
+HTSLIB_DIR=htslib-1.19.1
 PKG_CPPFLAGS=-I. -I${HTSLIB_DIR} -D_FILE_OFFSET_BITS=64
 PKG_LIBS=${HTSLIB_DIR}/libhts.a
 

src/vcfpp.h

@@ -1461,6 +1461,7 @@ class BcfWriter
     std::shared_ptr<bcf1_t> b = std::shared_ptr<bcf1_t>(bcf_init(), variant_close()); // variant
     int ret;
     bool isHeaderWritten = false;
+    kstring_t ks = {0, 0, NULL};
 
   public:
     /// header object initialized by initalHeader
@@ -1580,8 +1581,10 @@ class BcfWriter
         if(!isHeaderWritten && !writeHeader()) throw std::runtime_error("could not write header\n");
         std::vector<char> str(vcfline.begin(), vcfline.end());
         str.push_back('\0'); // don't forget string has no \0;
-        kstring_t s = {vcfline.length(), vcfline.length(), &str[0]}; // kstring
-        ret = vcf_parse1(&s, header.hdr, b.get());
+        ks.s = &str[0];
+        ks.l = vcfline.length();
+        ks.m = vcfline.length();
+        ret = vcf_parse1(&ks, header.hdr, b.get());
         if(ret < 0) hts_log_debug("the ret is %i ", ret);
         if(ret < 0) throw std::runtime_error("error parsing: " + vcfline + "\n");
         if(b->errcode == BCF_ERR_CTG_UNDEF)