FIX: Improved description message for mark_horizontal_lines and mark_vertical_lines fields
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahierhussain
requested review from
harini-venkataraman,
johnyrahul,
chandrasekharan-zipstack,
hari-kuriakose and
gaya3-zipstack
src/unstract/sdk/adapters/x2text/llm_whisperer_v2/src/static/json_schema.json
Outdated
Show resolved
Hide resolved
harini-venkataraman
approved these changes
Jan 17, 2025
johnyrahul
approved these changes
Jan 20, 2025
…son_schema.json Co-authored-by: harini-venkataraman <[email protected]> Signed-off-by: Tahier Hussain <[email protected]>
chandrasekharan-zipstack
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
@tahierhussain I hope we also throw an appropriate error to enforce this behaviour and not just rely on users using this description correctly
gaya3-zipstack
deleted the
fix/improve-description-for-mark-vertical-and-horizontal-lines-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added more context to the field description of
mark_horizontal_linesandmark_vertical_lines. Please refer it's corresponding OSS PR for a more detailed description.Why
...
How
...
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
...
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.