-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Env standardization for Backend. #1050
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. Some minor comments related to env sample is outstanding. But going ahead as this PR is a blocker for remote storage testing.
Signed-off-by: Gayathri <[email protected]>
|
Quality Gate passedIssues Measures |
What
PR focuses on standardizing the env values for backend employing the SDK base method.
...
Why
This is for the k8s deployment for uniform env values.
...
How
Knocking of native methods and using SDK methods.
...
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No, the changes are under feature flag.
...
Database Migrations
Not applicable.
...
Env Config
...
Relevant Docs
Not applicable.
...
Related Issues or PRs
Not applicable.
...
Dependencies Versions
Not applicable.
...
Notes on Testing
Tested the indexing, upload and answer prompt with and without flag.
Screenshots
Checklist
I have read and understood the Contribution Guidelines.