Fix range check #1309
Merged
Fix range check #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
reviewed
Jul 31, 2023
Schaeff
reviewed
Sep 28, 2023
| @@ -0,0 +1,67 @@ | |||
| { | |||
| "entry_point": "./tests/tests/range_check/assert_lt_u8_constant.zok", | |||
There was a problem hiding this comment.
Should we have a test with a value which is outside the u8 range and check that it fails, or is it handled in some other test for usize inputs?
| def main(field a) -> bool { | ||
| field p = FIELD_MAX + a; | ||
| // we added a = 0 to prevent the condition to be evaluated at compile time | ||
| return a < p; |
There was a problem hiding this comment.
The other tests down below all do assert(condition). Do we cover all cases which just use the condition without asserting it, for example returning it? They are handled differently in code generation so they should be also tested separately.
Schaeff
approved these changes
Nov 9, 2023
dark64
added a commit
that referenced
this pull request
Nov 9, 2023
* fix uint range check * update bit cache with correct bits * suggestions * js fmt * clippy * fix range check, add more tests * update changelog * fieldlt improvements * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1295 #1329