Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: attaching EmailSpellChecker to window + CDN #13

Closed
wants to merge 2 commits into from

Conversation

ferreiro
Copy link
Contributor

Description of change

Attaching EmailSpellChecker to window object so you all can use the script in your websites. This solves #10

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

build: attaching EmailSpellChecker to window + CDN
@ferreiro
Copy link
Contributor Author

This is not fully finished yet, we may need to do some updates on the build process to export both the node.js version, as well as the browser-ready version.

When I checked, it says the export variable wasn't found.

Check: #12

@ferreiro ferreiro force-pushed the ferreiro-cdn-window branch from 5c389af to bfee50a Compare October 24, 2022 21:58
@ferreiro ferreiro closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant