Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Refactor Bicycle Scheme #167

Merged
merged 2 commits into from
Apr 30, 2022
Merged

Refactor Bicycle Scheme #167

merged 2 commits into from
Apr 30, 2022
+227 −104

Conversation

droogmic
Copy link
Collaborator

@droogmic droogmic commented Apr 30, 2022 •
edited
Loading

Refactor bicycle.rs by injecting an intermediate Scheme.

This follows the scheme separation laid out by @BudgieInWA... somehwere? not sure which issue.

@droogmic
Refactor Bicycle Scheme
5fa2700 
Refactor bicycle.rs by injecting an intermediate Scheme
@droogmic
Copy link
Collaborator Author

This does not attempt to fix #149, #150, #152, #161, #162, #164, #165

dabreegster
dabreegster reviewed Apr 30, 2022
View reviewed changes
osm2lanes/src/transform/tags_to_lanes/modes/bicycle.rs
.into());
}
) -> Result<(), TagsToLanesMsg> {
let scheme = Scheme::from_tags(tags, locale, road.oneway, warnings)?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separating tag parsing from modifying still looks like a good approach to me -- nice. A good test of the code maintainability will come when we start parsing tagged cycle lane widths or separator info.

@droogmic droogmic merged commit c0aae09 into a-b-street:main Apr 30, 2022
@droogmic droogmic deleted the refactor_bicycle_scheme branch April 30, 2022 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dabreegster dabreegster dabreegster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@droogmic @dabreegster