Skip to content

Conversation

@enowmbi
Copy link
Contributor

@enowmbi enowmbi commented Oct 13, 2025

This PR updates the generator to streamline the installation process by reducing the number of manual steps required.
The goal is to improve the developer experience by making setup easier and more intuitive.

Changes Include:

  1. Added a few methods in the generator to include previously manual setup steps(install and run generators, add entry in routes.rb file).
  2. Updated documentation to reflect the simplified installation flow.

Benefits:

  1. Quicker onboarding for new users.
  2. Fewer opportunities for setup errors.
  3. Cleaner and more maintainable code in the generator.

Testing:

  1. Verified generator runs successfully with default and custom options.
  2. Confirmed that all generated apps function as expected post-installation.

Copy link
Owner

@a-chacon a-chacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please review the only comment I leave.

@enowmbi enowmbi force-pushed the Feature/UpdateGenerator branch from 8b0432b to e983439 Compare October 13, 2025 14:46
@a-chacon
Copy link
Owner

hey @enowmbi there are some tests failing. Take a look at it please! About the lint, don't worry, I can update dependencies on other PR.

@enowmbi
Copy link
Contributor Author

enowmbi commented Oct 13, 2025

sure, I'll take a look.

@enowmbi enowmbi force-pushed the Feature/UpdateGenerator branch from e983439 to 392de20 Compare October 13, 2025 16:42
@a-chacon
Copy link
Owner

hey @enowmbi still failing:

# Running:

The file /home/runner/work/rails-url-shortener/rails-url-shortener/test/dummy/tmp/generators/config/routes.rb does not appear to exist
...............................F

Failure:
RailsUrlShortener::RailsUrlShortenerGeneratorTest#test_generator_runs_without_errors [test/lib/generators/rails_url_shortener/rails_url_shortener_generator_test.rb:14]:
Expected file "config/initializers/rails_url_shortener.rb" to exist, but does not

bin/rails test test/lib/generators/rails_url_shortener/rails_url_shortener_generator_test.rb:10



Finished in 0.251549s, 127.2118 runs/s, 349.8324 assertions/s.
32 runs, 88 assertions, 1 failures, 0 errors, 0 skips

Sorry but I am working and I dont have time to check what is causing the problem.

@enowmbi
Copy link
Contributor Author

enowmbi commented Oct 13, 2025

ok, let me know if you find something.

@enowmbi enowmbi force-pushed the Feature/UpdateGenerator branch 2 times, most recently from bf3ba91 to d8d010f Compare October 18, 2025 03:45
@enowmbi
Copy link
Contributor Author

enowmbi commented Oct 18, 2025

@a-chacon, I think I fixed the broken tests. Looking forward to your approval and merging.

@enowmbi enowmbi force-pushed the Feature/UpdateGenerator branch from d8d010f to 6c97084 Compare October 18, 2025 03:51
@a-chacon
Copy link
Owner

@enowmbi thanks!

@a-chacon a-chacon merged commit 303b178 into a-chacon:main Oct 20, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants