Skip to content

Review a pull request

Frederic Tessier edited this page May 25, 2023 · 1 revision

All proposed changes in github will appear under the Pull requests tab. From there you can click on any pull request, review the changes, comment on them etc. You can view all the file modifications involved in a given pull request, under the Files changed tab.

👉 Click on any pull request to view changes, discuss or comment.

Just do it

If you want to suggest something, say removing a sentence, then just do it, commit, and create the pull request as explained above. Any ensuing discussion about this change can then happen in the pull request page, before the change is "approved" (merged in).

Don't worry, deleted content is not erased until the pull request is approved. In fact, it is never deleted: it is preserved in the commit history!. Consequently, please refrain from adding any sensitive information such as passwords (!) in the files. You can't remove it from the repository history afterwards (well you can if absolutely necessary, but it is difficult).