eslint: +custom fp/no-mutating-methods to allow Vue router

jfmengels/eslint-plugin-fp#54

.eslintrc.js

@@ -24,6 +24,12 @@ module.exports = {
     'vue/attribute-hyphenation': 0,
     'vue/require-prop-types': 0,
     'vue/require-default-prop': 0,
-    'vue/multiline-html-element-content-newline': 0
+    'vue/multiline-html-element-content-newline': 0,
+    // use fork to allow MemberExpressions
+    // https://github.com/jfmengels/eslint-plugin-fp/pull/54
+    "fp/no-mutating-methods": [2, {
+      "allowedObjects": ["$router"]
+    }]
+
   }
 }

package.json

@@ -56,7 +56,7 @@
     "eslint": "^7.15.0",
     "eslint-config-raine": "^0.1.2",
     "eslint-config-standard": "^16.0.2",
-    "eslint-plugin-fp": "^2.3.0",
+    "eslint-plugin-fp": "git+https://github.com/raineorshine/eslint-plugin-fp.git#allowedObjects",
     "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-jest-dom": "^3.6.4",
     "eslint-plugin-jsdoc": "^30.7.8",

src/App.vue

@@ -38,7 +38,6 @@ export default ({
       if (!prev && next && this.$store.state.noAccessPath.length) {
         const nap = this.$store.state.noAccessPath + ''
         this.$store.commit('setNAP', '')
-        // eslint-disable-next-line  fp/no-mutating-methods
         this.$router.push(nap)
       }
     }

src/components/BookmarkButton.vue

@@ -14,7 +14,6 @@ export default {
   methods: {
     toggleBookmark() {
       if (!this.$iam('authorized')) {
-        // eslint-disable-next-line fp/no-mutating-methods
         this.$router.push({ name: 'LogIn' })
       }
       else {

src/components/BooksFilter.vue

@@ -8,7 +8,6 @@ export default {
   methods: {
     toggleFilter(fid) {
       this.$store.commit('books/toggleFilter', fid)
-      // eslint-disable-next-line  fp/no-mutating-methods
       this.$router.push({ name: 'Home' })
     },
     resetFilters() {

src/components/MainMenu.vue

@@ -11,8 +11,6 @@ export default {
   methods: {
     logout() {
       firebase.auth().signOut()
-
-      // eslint-disable-next-line fp/no-mutating-methods
       this.$router.push({ name: 'LogIn' })
     }
   },

src/components/MobileFooter.vue

@@ -45,7 +45,6 @@ export default {
     },
     toggleBookmarks() {
       if (!this.$iam('authorized')) {
-        // eslint-disable-next-line fp/no-mutating-methods
         this.$router.push({ name: 'LogIn' })
         return
       }

src/components/RightBar.vue

@@ -31,7 +31,6 @@ export default {
     },
     toggleBookmarks() {
       if (!this.$iam('authorized')) {
-        // eslint-disable-next-line fp/no-mutating-methods
         this.$router.push({ name: 'LogIn' })
         return
       }

src/pages/AuthorDetail.vue

@@ -40,7 +40,6 @@ export default {
         // author not found! drop to 404
         // timeout to make router finish any his current work, if doing any
         setTimeout(() => {
-          // eslint-disable-next-line fp/no-mutating-methods
           this.$router.push('/404')
         }, 0)
       }

src/pages/BookManagerForm.vue

@@ -86,12 +86,9 @@ export default {
       })
     },
     save() {
-      /**/
       this.$store.dispatch('saveBook', { book: this.book, roles: this.authorsRoles }).then(() => {
-        // eslint-disable-next-line fp/no-mutating-methods
         this.$router.push({ name: 'BooksManager' })
       })
-      /**/
     },
     reloadCover() {
       this.searching = true

src/pages/BookSubmissionForm.vue

@@ -87,7 +87,6 @@ export default {
       this.$store.commit('ui/setBusy', true)
       await this.$store.dispatch('bookSubmissions/submit', this.submissions)
       this.$store.commit('ui/setBusy', false)
-      // eslint-disable-next-line fp/no-mutating-methods
       this.$router.push({ name: 'SubmissionThankYou', params: { type: 'book' } })
     },
     async saveDraft() {

src/pages/BundleManagerForm.vue

@@ -45,7 +45,6 @@ export default {
   methods: {
     save() {
       this.$store.dispatch('saveBundle', this.bundle).then(() => {
-        // eslint-disable-next-line fp/no-mutating-methods
         this.$router.push({ name: 'BundlesManager' })
       })
     },

src/pages/BundleSubmissionForm.vue

@@ -45,7 +45,6 @@ export default {
       }
       this.$store.dispatch('saveBundleSubmissionsDraft', data)
         .then(() => {
-          // eslint-disable-next-line fp/no-mutating-methods
           this.$router.push({ name: 'Dashboard' })
         })
     },
@@ -57,7 +56,6 @@ export default {
       }
       this.$store.dispatch('submitBundleSubmission', data)
         .then(() => {
-          // eslint-disable-next-line fp/no-mutating-methods
           this.$router.push({ name: 'Dashboard' })
         })
     },

src/pages/LogIn.vue

@@ -71,11 +71,9 @@ export default {
     '$store.state.user.user'(next, prev) {
       if (!prev && !!next) {
         if (this.$can('viewDashboard')) {
-          // eslint-disable-next-line fp/no-mutating-methods
           this.$router.push({ name: 'Dashboard' })
         }
         else {
-          // eslint-disable-next-line fp/no-mutating-methods
           this.$router.push({ name: 'Home' })
         }
       }
@@ -163,7 +161,6 @@ export default {
         password: this.password
       })
         .then(() => {
-          // eslint-disable-next-line fp/no-mutating-methods
           this.$router.push({ name: 'Dashboard' })
         })
       )
@@ -181,7 +178,6 @@ export default {
         ...this.signupData,
       })
         .then(() => {
-          // eslint-disable-next-line fp/no-mutating-methods
           this.$router.push({ name: 'Dashboard' })
         })
       )
@@ -235,7 +231,6 @@ export default {
       this.active = active
       this.error = null
 
-      // eslint-disable-next-line fp/no-mutating-methods
       this.$router.push({
         name: active === 'signup' ? 'Signup'
         : active === 'login' ? 'LogIn'

src/pages/PasswordReset.vue

@@ -10,7 +10,6 @@ export default {
   watch: {
     '$store.state.user.user'(next, prev) {
       if (!prev && !!next) {
-        // eslint-disable-next-line fp/no-mutating-methods
         this.$router.push({ name: 'Dashboard' })
       }
     }

src/pages/PeopleSubmissionForm.vue

@@ -87,7 +87,6 @@ export default {
       this.$store.commit('ui/setBusy', true)
       await this.$store.dispatch('bookSubmissions/submit', this.submissions)
       this.$store.commit('ui/setBusy', false)
-      // eslint-disable-next-line fp/no-mutating-methods
       this.$router.push({ name: 'SubmissionThankYou', params: { type: 'people' } })
     },
     async saveDraft() {

src/pages/PersonManagerForm.vue

@@ -78,7 +78,6 @@ export default {
     },
     save() {
       this.$store.dispatch('savePerson', this.person).then(() => {
-        // eslint-disable-next-line fp/no-mutating-methods
         this.$router.push({ name: 'PeopleManager' })
       })
     }