* Fix F841 problems in `scripts` directory

* Update `.flake8` with fixes for F841

* Remove unused lines based on reviewed suggestions

Path setup for ISIS was lost in GIS variable setup. This moves it to the library, where other paths and integrations are initialized.

The variables are left as is, without further testing.

This patch continues the work from 917ba58. It's a good
practice to immediately reset the file pointer once we
do fclose on it, as it prevents using/closing descriptor
allocated to another file in the future execution paths.

Signed-off-by: Mohan Yelugoti <[email protected]>

…_text (#4293)

… in scripts directory part 1 (#4238)

Currently, if 'HAVE_OGR' macro is defined, as part of execution,
we order all formats by name using qsort. But, list containing
all formats is assigned based on a conditional and if the
conditional fails, it can be NULL.
Behavior of qsort is undefined when a NULL ptr is passed as array
argument. To avoid getting into that situation, check if the array
is NULL before performing qsort on it.
This issue was found using cppcheck tool.

Signed-off-by: Mohan Yelugoti <[email protected]>

* g.gui.gmodeler: start refactoring

* assign results from _getLabel() directly instead of using intermediate vars

* do not run Getlabel() if not needed

* VariableListCtrl: simplify (no need to run one loop twice)

#4298)

* CI(deps): Update ruff to v0.6.4

* style: Fix List index lookup in `enumerate()` loop (PLR1736) in __writeNvizState

* style: Fix Unnecessary lookup of dictionary value by key (PLR1733) in iscatt_core.py

* style: Fix `enumerate` index is unused, use `for plane in constants` instead (FURB148) in __writeNvizState

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edouard Choinière <[email protected]>

Currently, filling list with GDAL driver names is based on
a conditional and if the conditional fails, the list can be NULL.

We pass this list to qsort to sort the names, but behavior
of qsort with a NULL array is undefined. To avoid getting into this
situation, check if the array is NULL before performing qsort on it.

This issue was found using cppcheck tool.

Signed-off-by: Mohan Yelugoti <[email protected]>

* create unit tests for r.proj

* change the source project

* update the validation values according to the map in the project

* remove shell cmd, update doc, modify precision

)

* v.vol.rst: Initialize structure contents before passing it around

`skip_point` structure is not initialized when declared. This was
found using cppcheck tool.

Only when `cv` is true, `skip_point` contents are filled and the
structure is used. cppcheck raised the issue when 'cv' is false.
Technically, we don't need skip_point in such cases and not
initializing it won't affect the execution. Nevertheless, it's a
good practice to initialize structure contents at the time of
declaration.

Signed-off-by: Mohan Yelugoti <[email protected]>

* Use correct literal for double type

Co-authored-by: Nicklas Larsson <[email protected]>

---------

Signed-off-by: Mohan Yelugoti <[email protected]>
Co-authored-by: Nicklas Larsson <[email protected]>

…4281)

* v.generalize: Initialize all of structure contents before using it

Currently, in `head` which is a `POINT_LIST` structure, we are
only initializing the next pointer to NULL, but data present
in the point substructure is not initialized which implies that
it would be filled with random data. To avoid such scenario,
initialize point coordinates to zero.

This was found using cppcheck tool.

Signed-off-by: Mohan Yelugoti <[email protected]>

* Use correct literal for double type

Co-authored-by: Nicklas Larsson <[email protected]>

---------

Signed-off-by: Mohan Yelugoti <[email protected]>
Co-authored-by: Nicklas Larsson <[email protected]>

* resolved flake8 in utils

* updated .flake8

---------

Co-authored-by: Arohan Ajit <[email protected]>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…ass.py (#4289)

* fixed flake8 errors in lib/init/grass.py

* fixed flake8 details .flake8

* drivers: copy into fixed size buffer issue

* Requested changes

* without variable

* Update db/drivers/sqlite/db.c

Co-authored-by: Nicklas Larsson <[email protected]>

* Use Db statements

---------

Co-authored-by: Nicklas Larsson <[email protected]>

)

* fixing TypeError ColumnSorterMixin #4277

* #4277 fix ColumnSorterMixin error

… in the temporal directory (#4229)

* resolved some more flake8 warnings

* fixed all man flake8 errors except buildhtml

* Update .flake8

---------
Co-authored-by: Arohan Ajit <[email protected]>

* revert 2cf98da

* fix regression introduced in f99780c

Add wrapper function for strlcat(), using system function if available, otherwise
uses implementation by Todd C. Miller originated from
https://github.com/openbsd/src/blob/e291b8af02e5c2b53d7ddb1f0c9c0fd608b97d45/lib/libc/string/strlcat.c.

G_strlcat() is a safer alternative to strcat().

Use G_getl2 in G_getl to have everywhere the same behavior of supporting all newlines. Originally, G_getl2 was created to keep the behavior of G_getl. However, now, we want G_getl2 behavior everywhere.

Keeping G_getl2 for compatibility. Code can later be clean up to use only G_getl, probably at the time when G_getl2 is removed (v9).

The new test fails without the change in the library for CRLF for G_getl, but passes with the change. CR fails because it is not supported by fgets used since 88090da (#3850), so expecting failure for CR.

Return and argument types for ctypes fopen need to be set for the code to work everywhere reliably.

---------

Co-authored-by: Nicklas Larsson <[email protected]>

…4052)

* style: Fix all flake8-gettext (INT) errors (INT001, INT002, INT003)

Ruff rules:
https://docs.astral.sh/ruff/rules/f-string-in-get-text-func-call/
https://docs.astral.sh/ruff/rules/format-in-get-text-func-call/
https://docs.astral.sh/ruff/rules/printf-in-get-text-func-call/

* Revert source string changes when unneeded.

* Update univar_statistics.py

Co-authored-by: Vaclav Petras <[email protected]>

* Update panels.py for Python script type string

* Update pyedit.py to keep path keyword in changed string

* Update univar_statistics.py to make already translated strings match again

* Update pyedit.py

* Update model.py

---------

Co-authored-by: Vaclav Petras <[email protected]>

…printf (#4262)

v.in.dwg: Avoid using same variable as parameter and dest in sprintf

Currently, one instance of sprintf has the same variable as parameter
and destination in sprintf. This scenario leads to undefined
behavior in C.

Modify the code to:

1. Write initial error string using snprintf() onto the buffer.
   Using snprintf() makes sure that we stay within the buffer size
   and avoid overflow errors.

2. Use snprintf() again to write another error string at the end
   of previous error string in the same buffer. We again use
   snprintf() to make sure we are not overflowing the buffer with
   data.

Signed-off-by: Mohan Yelugoti <[email protected]>

Fixes problems with loading environment variables and path on the newest GitHub Actions macOS 20240911.3 runner image, that makes all builds fail.

* CI(macOS): Use micromamba-shell for build and install

* CI(macOS): Use micromamba-shell for printing versions

* CI(macOS): Use micromamba-shell for pytest and gunittest

…4326)

With the current GitHub Hosted runners, the build step time is reduced by about 2 minutes, down to about 8min30 instead of about 10min30, for the couple builds I observed

)

* CI(deps): Update ruff to v0.6.5

* style: Fix FURB188: Prefer `removeprefix` over conditionally replacing with slice.

Ruff rule: https://docs.astral.sh/ruff/rules/slice-to-remove-prefix-or-suffix/

This is a new rule introduced in ruff 0.6.5

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Edouard Choinière <[email protected]>

This change addresses an issue identified by Coverity Scan (CID : 1415709) [unchecked return value from library]. The checks are added for lseek usages using an error message already used in the library.

---------

Co-authored-by: Edouard Choinière <[email protected]>

* Handling Resource Leak

* Resource Leak

* r.viewshed: initialize struct member before using struct

This was reported by cppcheck tool. Technically, we are not using
the member in the struct variable in any of the subsequent
functions, but it's a good practice to initialize all the struct
members whenever possible.

Signed-off-by: Mohan Yelugoti <[email protected]>

* Use right literal while initializing angle

Signed-off-by: Mohan Yelugoti <[email protected]>

---------

Signed-off-by: Mohan Yelugoti <[email protected]>

…fy module (#4299)

* Copy into fix size buffer issue

* removed variable Len

* Update imagery/i.rectify/main.c

Co-authored-by: Nicklas Larsson <[email protected]>

---------

Co-authored-by: Shubham Vasudeo Desai <[email protected]>
Co-authored-by: Shubham Vasudeo Desai <[email protected]>
Co-authored-by: Nicklas Larsson <[email protected]>

* remove unused variable

* Specify old ideas in the comment explicitly

---------

Co-authored-by: Vaclav Petras <[email protected]>

…es (#4330)

- various minor updates
- removal of GRASS Travis CI section

…ast.univar and t.rast3d.univar (#4334)

Several documents and files contain references to documents on https://trac.osgeo.org/grass/wiki/ while newer versions exist in GitHub. This PR updates a series of URLs and drops the outdated files `CHANGES` and `NEWS`.
Additionally, some minor markdown fixes.

…oad SQL template files (#4335)

grass.temporal.abstract_space_time_dataset: Use Path.read_text() to load SQL template files

Fixes ResourceWarnings about unclosed files, fixing ruff SIM115 at the same time.

These 4 places were opening a file and reading it completely in the same line, but never closed explicitly the file, nor used a context manager that would kick in as much as possible on errors inside the calls.

…#4332)

Make local implementations of strlcpy() and strlcat() optimizable by
using restrict type qualifier, while keeping public API for G_strlcat
and G_strlcpy available to C++ code and having identical prototype and
declaration.

…4324)

* grass.gunittest: Ensure file list exists before processing exclusions

* grass.gunittest: Use pathlib.Path to handle test files across platforms

* grass.gunittest: Use pathlib.PurePath instead of concrete pathlib.Path

* grass.gunittest: Also use pathlib.PurePath for patterns

* grass.gunittest: Simplify pathlib filtering using a set comprehension

* grass.gunittest: Add typing to fnmatch_exclude_with_base signature

* style: Sort imports with isort

* Add Edouard Choinière (echoix) to the authors

* Fix typo in comment

* grass.gunittest: Filter file list respecting all three filter arguments if specified

* grass.gunittest: Change set comprehension variable name

* grass.gunittest: Use a context manager for opening htmldiff_file

* grass.gunittest: Specify encoding for writing htmldiff_file

* grass.gunittest: Write all lines of htmldiff_file at once

* grass.gunittest: Use Path.write_text() to write htmldiff_file

* grass.gunittest: Use a context manager for opening actual and reference files (SIM115)

* grass.gunittest: Use a context manager for output StringIO in case.py

* grass.gunittest: Use a context manager for opening files (SIM115)

In function replace_in_file of reporters.py

* grass.gunittest: Use a context manager for opening files (SIM115)

In function wrap_stdstream_to_html of reporters.py

* grass.gunittest: Use a context manager for opening files (SIM115)

In function report_for_dirs of reporters.py. Reordered so string creation ends up together outside the context manger where the file is written.

* grass.gunittest: Use a context manager for opening files (SIM115)

In function end_file_test of class GrassTestFilesHtmlReporter of reporters.py. Reordered so string creation ends up together outside the context manger where the strings are written to the file.

* grass.gunittest: Use a context manager for opening files (SIM115)

In function report_for_dir of class TestsuiteDirReporter of reporters.py

* grass.gunittest: Ignore remaining two SIM115 in reporters.py

* grass.gunittest: Use a context manager for opening files in multireport (SIM115)

* style: Enable checking of SIM115

)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

v.in.dwg is linked to proprietary library 'OpenDWG toolkit'. One needs to become a member of OpenDWG Alliance to get the needed libraries and headers in order to compile this tool.

However, OpenDWG webpage went offline around 2011 and we have 'v.in.redwg' as replacement for it (available in grass-addons). Hence retire 'v.in.dwg' tool.

Besides the tool, this completely removes OpenDWG from configure.ac and platform.

Signed-off-by: Mohan Yelugoti <[email protected]>

Replace outdated direct use of Fortran libraries via g2c.h,  f2c.h
or private prototypes, with the C interface API and libraries
CBLAS and LAPACKE. This simplifies our own code and makes
it easier to maintain and expand.

Configure is simplified to use pkg-config to retrieve INC and
LIB info. `--with-blas` defaults to `--with-blas=cblas` where "cblas"
is the pkg-config package name; `---with-lapack` defaults to
`--with-lapack=lapacke`.

If the default fails the test a list of package names are tested:
- BLAS package names tested: cblas blas-netlib openblas blas-atlas
- LAPACKE package name tested: lapacke openblas

- CI(Linux): replace libopenblas-dev with liblapacke-dev dependency
- CI(macOS): replace blas and lapack with openblas dependency
- CI(Windows): replace lapack with openblas dependency

- move Programmer's manual creation from `doc/development/README.md` to `INSTALL.md`.

update `doc/development/README.md`
- add Python API; add subsections
- update URLs and wording
- list guides

- remove stray control chars (visible in vim) in `doc/development/style_guide.md`

In addition: improve handling of configuration with LAPACK
without BLAS

Removes the lines with unused assignments with 90%. The variable eps 90% value got overwritten. The used 99% confidence interval is mentioned in the documentation.

Fixes the issue identified by Coverity Scan (CID: 1270389).

* CI(macOS): Cache micromamba environment on same day

* Use year and week of year for cache key date segment

* Update macos.yml

Co-authored-by: Vaclav Petras <[email protected]>

---------

Co-authored-by: Vaclav Petras <[email protected]>

)

* style: Bump Black's target Python versions

* style: Format with new Black settings

…4348)

style: Call `startswith` once with a `tuple` (PIE810)

Ruff rule: https://docs.astral.sh/ruff/rules/multiple-starts-ends-with/

After left double mouse click on the wxGUI history tab tree cmd node.

Special cmds are:

```
r"^d\..*|^r[3]?\.mapcalc$|^i.group$|^r.import$|^r.external$|^r.external.out$|"
r"^v.import$|^v.external$|^v.external.out$"
```

…4290)

* CI(OSGeo4W): Use setup-OSGeo4W action to parametrize instal options

* Remon extra double quote

* Remove unnecessary space in OSGeo4W workflow file

* CI: Multiline sorted OSGeo4W package list

Rename file to reflect changes made with
d5bb442

This addresses F403 and F405. These are mostly related to wild card imports. This does not touch max line length issue with long tool description documentation line (current format limitation).

Co-authored-by: Shubham Vasudeo Desai <[email protected]>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

)

* tests: Re-enable passing tests from .gunittest.cfg exclusion list

* tests: Re-enable all macOS excluded tests that are passing

* tests: Exclude back tests that are failing on macOS

Moves imports to the top to fix Flake8 E402 warning for wxGUI/core.

Also orders ignores alphabetically.

)

* grass.gunittest: Add xfail_windows decorator for Windows expected failures

* lib/imagery: Add xfail_windows decorator to test functions

* Fix spacing issue in xfail_windows warning message

* Add stacklevel=2 to xfail_windows decorator warning message

* Update utils.py

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Format end of file

* Comment out warning in decorator

* i.maxlik: Add xfail_windows decorator to SuccessTest class

* lib/gis: Add xfail_windows decorator to TestNewlinesWithGetlFunctions class

* Update warning stacklevel to 3

* Update utils.py

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update utils.py

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update utils.py

* tests: Add expected failures to failing tests on windows

* tests: Apply xfail_windows decorator to setUpClass in lib/gis getl tests

* tests: Apply xfail_windows decorator to parser json tests in lib/gis

* tests: Apply xfail_windows decorator to failing test in lib/imagery

* Remove wrong import of xfail_windows

* tests: Temporarily remove all gunittest exclusions

* tests: Apply xfail_windows decorator to failing test in test_gcmd.py

* tests: Apply xfail_windows decorator to failing test in lib/init in test_grass_tmp_mapset.py

* CI(OSGeo4W): Use an OSGeo4W-specific gunittest.cfg config file

* Revert "tests: Temporarily remove all gunittest exclusions"

This reverts commit 20eb947.

* v.out.lidar: Apply xfail_windows decorator to one failing test

* t.rast.series: Apply xfail_windows decorator to failing tests

* t.connect: Apply xfail_windows decorator to three failing tests

* g.search.modules: Apply xfail_windows decorator to a failing test

* grass.temporal: Apply xfail_windows decorator to failing tests in unittests_temporal_raster_algebra_equal_ts

* grass.gunittest: Apply xfail_windows decorator to failing test test_assertVectorEqualsAscii_by_import

* tests: Re-enable excluded tests that are not failing on Windows

* tests: Re-enable passing tests from .gunittest.cfg exclusion list

* Update test_gis_lib_getl.py

* Update test_raster_img.py

* tests: Try re-enabling python/grass/script/testsuite/test_script_doctests.py

* i.maxlik: Add xfail_windows decorator to all tests in class

* tests: Exclude more tests that are failing on Windows

* v.univar: Apply xfail_windows decorator to failing tests

* t.rast.univar: Apply xfail_windows decorator to a failing test

* r.in.gdal: Try avoiding error in calling gdal-config in skipif decorator on Windows

* CI(OSGeo4W): Increase min-success to 96% for gunittest

* Add line in test_grass_tmp_mapset.py

* Update test_r_tileset.py

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* grass.temporal: fix regression in printing metadata

* Update python/grass/temporal/metadata.py

Co-authored-by: Stefan Blumentrath <[email protected]>

---------

Co-authored-by: Stefan Blumentrath <[email protected]>

)

This addresses the PEP8 style error of mentioning specific exceptions (Flake8 E722) by specifying the exception type in the except clause within the writejson function in grass_po_stats.py. Now, bare except is replaced by OSError to catch only OS-related exceptions because os.remove() can raise various OS-related exceptions such as FileNotFoundError or PermissionError.

Additionally, it confirms that no other common Flake8 errors (E122, E128, E231, E401) are present in the file by removing the other ignores.

This adds tests for different outputs of the g.version tool using pytest.

This addresses resource leak issue identified by Coverity Scan (CID : 1207906). Uses Vect_destroy_cats_struct() to destroy Cats and avoid the memory leak issue.

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Adds liblapacke-dev package that was added to the apt.txt of the grass-addons repo.

The interpolated path strings aren't escaped when evaluated, so using a
raw string allows C:\Users to not have an invalid \U escape sequence.