Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F841 E722 and F405 #20

Merged
merged 35 commits into from
Oct 29, 2024
Merged

F841 E722 and F405 #20

merged 35 commits into from
Oct 29, 2024

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    a4786e1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d699d5 View commit details
    Browse the repository at this point in the history
  3. style: Fix if-else-block-instead-of-if-exp (SIM108) (part 2) (#4562)

    * style: Fix if-else-block-instead-of-if-exp (SIM108) in scripts/
    
    Ruff rule: https://docs.astral.sh/ruff/rules/if-else-block-instead-of-if-exp
    
    * style: Fix if-else-block-instead-of-if-exp (SIM108) in python/
    
    Ruff rule: https://docs.astral.sh/ruff/rules/if-else-block-instead-of-if-exp
    
    * checks: Rename inner variable shadowing type to _type in python/grass/temporal/gui_support.py
    
    * style: Manual fixes for if-else-block-instead-of-if-exp (SIM108) in python/
    
    Ruff rule: https://docs.astral.sh/ruff/rules/if-else-block-instead-of-if-exp
    echoix authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    67a1609 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    af55fa7 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    c5c42cf View commit details
    Browse the repository at this point in the history
  2. wxGUI: Fixed F841 in photo2image/ (#4573)

    * fixed 841
    
    * fixed busyInfo
    arohanajit authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2575783 View commit details
    Browse the repository at this point in the history
  3. lib/db: Remove deprecated implementation of db_get_login() and replac…

    …e it with that of db_get_login2() (#4302)
    
    `db_get_login()` is deprecated in 7.8.0 release with da399c5. Change its function signature and implementation to match that of the currently preferred `db_get_login2()`. Technically, this is removing the old function and introducing a new one with the same name, but a different signature.
    
    Modify `db_get_login2()` to internally call `db_get_login()` function call. In the next major version, `db_get_login2()` should be removed to have only one method to get login details for simplicity.
    
    See also #4308.
    
    ---------
    
    Signed-off-by: Mohan Yelugoti <[email protected]>
    ymdatta authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a05ed29 View commit details
    Browse the repository at this point in the history
  4. lib/db: Remove deprecated implementation of db_set_login() and replac…

    …e it with that of db_set_login2() (#4308)
    
    `db_set_login()` is deprecated in 7.8.0 release with da399c5. Change its function signature and implementation to match that of the currently preferred `db_set_login2()`. Technically, this is removing the old function and introducing a new one with the same name, but a different signature.
    
    Modify `db_set_login2()` to internally call `db_set_login()` function call. In the next major version, `db_set_login2()` should be removed to have only one method to get login details for simplicity.
    
    See also #4308.
    
    ---------
    
    Signed-off-by: Mohan Yelugoti <[email protected]>
    ymdatta authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    930d59a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5cd6870 View commit details
    Browse the repository at this point in the history
  6. style: Fix unused-import (F401) (#4521)

    * t.rast.accumulate: Remove unused SimpleModule import in test_accumulation
    
    * temporal: Fix unused-import (F401) in testsuite
    
    * grass.temporal: Fix unused-import (F401)
    
    * grass.benchmark: Fix unused-import (F401) by defining __all__
    
    * grass.pygrass.vector: Fix unused-import (F401) for testsuite
    
    * grass.pygrass.vector: Sort imports
    
    * vector: Fix unused-import (F401) for testsuite
    
    * scripts: Fix unused-import (F401) for testsuite
    
    * raster: Fix unused-import (F401) for testsuite
    
    * v.fill.holes: Fix unused-import (F401)
    
    * doc: Fix unused-import (F401)
    
    * grass.semantic_label: Fix unused-import (F401) by defining __all__ in __init__
    
    * grass.pygrass.rpc: Fix unused-import (F401) in __init__
    
    * grass.pygrass.modules.interface: Fix unused-import (F401) by defining __all__ in __init__
    
    * grass.pygrass.modules.interface: Apply isort
    
    * grass.pygrass.modules.grid: Fix unused-import (F401) by defining __all__ in __init__
    
    * grass.pygrass.modules: Fix unused-import (F401) by defining __all__ in __init__
    
    * grass.pygrass.modules: Apply isort
    
    * grass.imaging: Fix unused-import (F401) by defining __all__ in __init__
    
    * grass.imaging: Apply isort
    
    * grass.jupyter: Fix unused-import (F401) by defining __all__ in __init__
    
    * grass.jupyter: Apply isort
    
    * pygrass: Ignore F401 (unused imports)
    
    Ignored inline where the import is justified and isn't to fix later, and ignored in a per-file exclusion where the imports seemed to be for commented-out test case lines
    
    * lib/gis: Fix F401 unused platform import in test_gis_lib_getl
    
    * grass.script: Ignore F401 in `__init__.py` for setup import
    
    * style: Remove exclusion for F401 ruff rule
    
    * style: Remove unneeded flake8 exclusions for F401
    
    * Apply suggestions from code review
    echoix authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    533070d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0582709 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3d7b331 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    cc0fb73 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Configuration menu
    Copy the full SHA
    0860b87 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bbe66e4 View commit details
    Browse the repository at this point in the history
  3. tests: Add regression test for r.his (#4572)

    * Add tests to r.his
    
    * Add assertRasterFitsUnivar
    
    * Update assertRasterFitsUnivar
    
    * Add g.region to make r.univar values consistent
    
    * Update raster/r.his/testsuite/test_r_his.py
    
    Apply the suggestion.
    
    Co-authored-by: Anna Petrasova <[email protected]>
    
    * Update raster/r.his/testsuite/test_r_his.py
    
    Apply the suggestion.
    
    Co-authored-by: Anna Petrasova <[email protected]>
    
    * Update raster/r.his/testsuite/test_r_his.py
    
    Black styling
    
    ---------
    
    Co-authored-by: Anna Petrasova <[email protected]>
    mshukuno and petrasovaa authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b6514ca View commit details
    Browse the repository at this point in the history
  4. manual: mention raster semantic labels and multiple http/https fixes (#…

    …4591)
    
    * r.support/i.band.library/r.semantic.label: better mention raster semantic labels
    * v.db.reconnect.all: add missing keywords
    * URLs: selectively change http to https; fix a few broken URLs
    neteler authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5b94314 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    86693f6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1a04b64 View commit details
    Browse the repository at this point in the history
  7. style: Fix if-else-block-instead-of-if-exp (SIM108) (part 3) (#4570)

    * style: Fix if-else-block-instead-of-if-exp (SIM108) in scripts/
    
    Ruff rule: https://docs.astral.sh/ruff/rules/if-else-block-instead-of-if-exp
    
    * style: Fix if-else-block-instead-of-if-exp (SIM108) in python/
    
    Ruff rule: https://docs.astral.sh/ruff/rules/if-else-block-instead-of-if-exp
    
    * checks: Rename inner variable shadowing type to _type in python/grass/temporal/gui_support.py
    
    * style: Manual fixes for if-else-block-instead-of-if-exp (SIM108) in python/
    
    Ruff rule: https://docs.astral.sh/ruff/rules/if-else-block-instead-of-if-exp
    
    * style: Fix if-else-block-instead-of-if-exp (SIM108) in gui/
    
    Ruff rule: https://docs.astral.sh/ruff/rules/if-else-block-instead-of-if-exp
    
    * checks: Rename inner variable shadowing list to _list in gui/wxpython/core/render.py
    
    * style: Manual fixes for if-else-block-instead-of-if-exp (SIM108) in gui/
    
    Ruff rule: https://docs.astral.sh/ruff/rules/if-else-block-instead-of-if-exp
    
    * python: Add type annotations for grass.script.core.parser()
    
    * python: Add type annotations for is_time_absolute() and is_time_relative() in grass.temporal.AbstractDataset
    
    * style: Enable Checking for SIM108
    
    * Update pyproject.toml to remove fixed issues
    
    * Update base.py
    
    Co-authored-by: Anna Petrasova <[email protected]>
    
    ---------
    
    Co-authored-by: Anna Petrasova <[email protected]>
    echoix and petrasovaa authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9e1e85d View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. wxGUI: Reverted unused variable fix in wxgui/ (#4595)

    Seems to break 3D view
    arohanajit authored Oct 26, 2024
    Configuration menu
    Copy the full SHA
    ac49177 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    652a2f8 View commit details
    Browse the repository at this point in the history
  3. lib/iostream: Remove redundant template parameters (#4586)

    In C++20, repeating template parameter names with the name of the class is no longer allowed as it is redundant (https://cplusplus.github.io/CWG/issues/2237.html). The new code is valid also in C++17, but the old code is not accepted in C++20.
    wenzeslaus authored Oct 26, 2024
    Configuration menu
    Copy the full SHA
    5af22b2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4616b9d View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. Configuration menu
    Copy the full SHA
    7910777 View commit details
    Browse the repository at this point in the history
  2. temporal: Add precise typing overloads to dataset_factory (#4600)

    * temporal: Add precise typing overloads to dataset_factory
    
    This enables type checkers like mypy or Pyright to understand the returned class from the string passed as the type argument
    
    * temporal: Add typing overloads to dataset_factory
    
    * temporal: Add dataset_factory implementation with str type for type argument
    
    * temporal: Remove dataset_factory overload that listed all literal types
    
    * temporal: Update dataset_factory file header
    
    * temporal: Add dataset_factory overload with str type for type argument
    
    * temporal: Accept None for id argument in dataset_factory overload as used in existing calls
    echoix authored Oct 27, 2024
    Configuration menu
    Copy the full SHA
    ffcb9e1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    84afcf4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    937b2f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Configuration menu
    Copy the full SHA
    7d101ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    24469d8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6bceb98 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b9a543a View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Configuration menu
    Copy the full SHA
    94034a3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba809db View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e6fd110 View commit details
    Browse the repository at this point in the history