GRASS GIS Updates and Improvements #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* v.out.ogr: faster export with many attributes --------- Co-authored-by: Edouard Choinière <[email protected]>
In order to obtain a good result when converting the HTML manual pages files to markdown, ideally clean HTML code is used. This PR fixes numerous broken HTML tags identified during a test run of [adding HTML validation with super-linter](echoix#303). For reference, see logs showing the errors at https://github.com/echoix/grass/actions/runs/12001379426/job/33451802353?pr=303#step:4:8310 Fixes: - incomplete tag pairs - tabs replaced with white space - fix missing .html extension in URLs
Fix Resource Leak issue
* db/MySQL: fix HTML manual nested `<ul></ul>` element position
Fix `HTMLParser()` class instance find nested `<ul>` end element `</ul>`
error during compilation GRASS GIS source code:
```
Error (IndexError('pop from empty list'))
```
Problematic is nested `<ul></ul>` HTML element inside parent `<ul></ul>`
element:
```
<ul>
<li></li>
<li></li>
<ul>
<li></li>
<li></li>
<li></li>
</ul>
</ul>
```
Expected nested `<ul></ul>` HTML element inside parent `<ul></ul>` is
nested position inside `<li></li>` element.
```
<ul>
<li></li>
<li>
<ul>
<li></li>
<li></li>
<li></li>
</ul>
</li>
</ul>
```
* Fix typo of key word
Fix Copy into buffer size issue
* manual: fix more broken HTML tags In order to obtain a good result when converting the HTML manual pages files to markdown, ideally clean HTML code is used (continuation of #4765). This PR fixes numerous broken HTML tags identified during a test run of [adding HTML validation with super-linter](echoix#303). For reference, see logs showing the errors at https://github.com/echoix/grass/actions/runs/12067630007/job/33651008404?pr=303 Fixes include: - complete selected ncomplete tag pairs (esp. `<li>`) - tabs replaced with white space - `<`, `>`, `&` replaced with their HTML representations * Apply suggestions from code review --------- Co-authored-by: Edouard Choinière <[email protected]>
…4783) with a simple version check in the code to speed up configure process
* Resource Leak * Suggested changes
Fix Resource Leak
va_list() macro initializes va_list structure before it's usage, and each va_list() call has to be accompanied by corresponding va_end() macro call on the same va_list structure. By having these macros directly before and after the va_list structure usage, reduces the number of places we need to keep track of whether the va_list structure was properly inintialized or closed. Signed-off-by: Mohan Yelugoti <[email protected]>
* CI(deps): Update ruff to v0.8.1 * style: Fix RUF055 [*] Plain string pattern passed to `re` function * style: Fix or ignore os-listdir (PTH208) Use `pathlib.Path.iterdir()` instead. Ruff rule: https://docs.astral.sh/ruff/rules/os-listdir/ --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Edouard Choinière <[email protected]>
… Explicit Imports in __init__.py (#4736) * update * Apply suggestions from code review * renamed temoral to temporal in init --------- Co-authored-by: Edouard Choinière <[email protected]>
Fix wrong message translation in `v.distance`: "distancia máxima --> distancia mínima" Fixes #4855
* r.resamo.filter: update manual
…ring()` (#4840) `grass.temporal.datetime_math.datetime_to_grass_datetime_string()` checks for `None`, and handles the case where it is `None`, so the `dt` argument can safely be `None`. This fixes some pylance type checking errors in `_pretifyTimeLabels()` of gui/wxpython/animation/temporal_manager.py, which rightfully detected that the result of `tgis.string_to_datetime(start)` can be either `datetime` or `None` and that `None` wouldn't be accepted into `datetime_to_grass_datetime_string()`.
…ebra.py (#4842) Fixes the following Pylance error: Method declaration "test_temporal_select" is obscured by a declaration of the same name
… in r.geomorphon manual page (#4831) * fix typo
* updated 841 * updated as per review * update * unassigned key variable fixed
* Fix Resource Leak issue * Formatting * Fix
* style: Fix raw-string-in-exception (EM101) Exception must not use a string literal, assign to variable first Produces a clearer stack trace, without duplicating the text of the error message Ruff rule: https://docs.astral.sh/ruff/rules/raw-string-in-exception/ * style: Fix f-string-in-exception (EM102) Exception must not use an f-string literal, assign to variable first Produces a clearer stack trace, without duplicating the text of the error message Ruff rule: https://docs.astral.sh/ruff/rules/f-string-in-exception/ * style: Fix dot-format-in-exception (EM103) Exception must not use a `.format()` string directly, assign to variable first Produces a clearer stack trace, without duplicating the text of the error message Ruff rule: https://docs.astral.sh/ruff/rules/dot-format-in-exception/ * checks(ruff): Enable checking for EM101, EM102 and EM103 rules * Fix doctest typo according to current error message
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* style: Fix pointless-string-statement / W0105 Change useless string statement with a comment Pylint rule: https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/pointless-string-statement.html * Update plots.py
…4873) Current code didn't handle the case where angle is 0, nor if out of range (more than 360 degrees). For example, calling with an angle of 375.7 will try to compute the width and height on variables not set yet. This handles these two cases, and short-circuits for an angle of 0 degrees. Angles greater than 360 degrees can be supported by this, but range documented is kept as is.
…lated variables in core.menutree (#4874)
Fully type check and annotate convertRGB() and the grass.script.core.parse_color() functions
* Add testsuite files for r.distance * Added function descriptions * Stripped Carriage Returns for windows-2019 build and tests * Changed maps and tuned asserts to rectify earlier build fails * Corrected maps in 3rd test * fix for windows build issues and doc correction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: GRASS GIS Updates and Improvements
This pull request includes various updates, bug fixes, and improvements to the GRASS GIS project. The changes span across multiple areas, including CI dependencies, documentation, code refactoring, and bug fixes.
CI and Dependency Updates
Performance Improvements
Documentation Updates
Code Refactoring and Cleanup
Bug Fixes
Other Improvements