* CI: add nix package and dev environment test

* nix: exclude more files from package source

---------

Co-authored-by: Edouard Choinière <[email protected]>

… value warnings in bar.c (#3923)

The change satisfies the warning and does not change the behavior. The initial values (garbage or 0) are actually not used. `is_fp` conditions are used to set the values and drive their use (so that the initial values are not used).

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Rename self.l to self.item_attr when using self.l as an argument to wx.ItemAttr().

* Rename l to layer when using l for loop through layer list.

* Rename l to new_layer_lst when using l as an argument to self._tree.AddLayer().

* Rename l to rli_conf when looping through the configuration files in self.rlipath.

* Rename l to layer when looping through the self.map_.GetListOfLayers().

* Rename l to dataset_info when sorting `allDatasets` with the lambda function.

* Rename l to layer_num when looping through `catsDict.items()`.

* Rename l to layer when retrieving layer information in a function.

* Rename l to curr when looping through the `curr_sel_ls`.

* Remove E741 for files in gui/wxpython directory.

* d.histogram: Remove unnecessary assignment of draw variable in bar.c

…3948)

* style: Fixes unnecessary-collection-call (C408) for remaining code

Only applies fixes to non-empty collections by  `ruff check --select "C408" --unsafe-fixes --output-format=concise --fix` in order to limit the review scope.

* style: Apply black formatting

Separated in another commit for easier review of only the original changes without formatting

* style: Fixes unnecessary-collection-call (C408) for ctypesgen

Only applies fixes to non-empty collections by  `ruff check --select "C408" --unsafe-fixes --output-format=concise --fix` in order to limit the review scope.

* style: Fixes unnecessary-collection-call (C408) for gui/wxpython/psmap/instructions

* style: Adjust comment in gui/wxpython/psmap/instructions

* style: Remove comment in gui/wxpython/psmap/instructions

Concerns Pylint rule "consider-using-from-import / R0402"

Using `ruff check --output-format=concise --select PLR0402 --fix`.

* style: Fixes unnecessary-collection-call (C408) for testsuite

Only applies fixes to non-empty collections by  `ruff check --select "C408" --unsafe-fixes --output-format=concise --fix --config 'include = ["*/testsuite/**.py"]'` in order to limit the review scope.

* style: Apply black formatting

Separated in another commit for easier review of only the original changes without formatting

Concerns Pylint rules "consider-using-min-builtin / R1730" and "consider-using-max-builtin / R1731"

Using `ruff check --output-format=concise --select PLR1730 --preview --fix`.

* style(gui/wxpython): Fixes literal-membership (PLR6201)

Concerns Pylint rule "use-set-for-membership / R6201"

Using `ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix gui/`.

* style: Apply single element in set formatting

Concerns Pylint rule "use-set-for-membership / R6201"

Using `ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix 'temporal/' 'python/grass/temporal'`.

Concerns Pylint rule "use-set-for-membership / R6201"

Using `ruff check --output-format=concise --select PLR6201 --preview --unsafe-fixes --fix`, but reverting some changes where it wasn't clear if it was safe.

Using  `ruff check --select "PLR1722" --unsafe-fixes --output-format=concise --fix`.

When building the image, only PROJ 8.2.1 is available, and PDAL 2.7.2 checks for PROJ 9.0+. Reverting until the Dockerfile is modified to include PROJ 9.0+

…lations (ISC001) (#3944)

* style: Manual fixes for single-line-implicit-string-concatenation violations (ISC001)

Applies the remaining fixes that weren't picked up by `ruff check --select "ISC001" --fix` in order to limit the review scope.

* style: Manual fixes for single-line-implicit-string-concatenation violations (ISC001) in ctypesgen code

Applies the remaining fixes that weren't picked up by `ruff check --select "ISC001" --fix` in order to limit the review scope.

Concerns Pylint rule "useless-return / R1711"

Using `ruff check --output-format=concise --select PLR1711 --fix`.

Concerns Pylint rule "pointless-exception-statement / W0133"

Using `ruff check --output-format=concise --select PLW0133 --unsafe-fixes --fix`.

* style(temporal): Sort and group imports

Uses a combination of `ruff check --output-format=concise --select I --fix 'temporal/' 'python/grass/temporal'`, `isort --profile=black temporal python/grass/temporal` and `black .`

* style(temporal): Sort and group imports for __init__.py

…#3945)

* style: Fixes unnecessary-collection-call (C408) for empty collections

Only applies fixes to empty collections by  `ruff check --select "C408" --unsafe-fixes --fix --config "lint.flake8-comprehensions.allow-dict-calls-with-keyword-arguments = true"` in order to limit the review scope.

* style: apply black

* Apply suggestions from code review

---------

Co-authored-by: Stefan Blumentrath <[email protected]>

…01) (#3943)

* style: Fix single-line-implicit-string-concatenation violations (ISC001)

Only applies safe fixes with `ruff check --select "ISC001" --fix` in order to limit the review scope.

* style: Apply black formatting

Separated in another commit for easier review of the changes of the first commit

Co-authored-by: Shubham Vasudeo Desai <[email protected]>

Concerns Pylint rule "unnecessary-lambda / W0108"

Using `ruff check --output-format=concise --select PLW0108 --preview --fix --unsafe-fixes`.

Didn't apply to cases where it wasn't clear if it was safe

…ep.cpp (#3966)

Fix uninitialized variable 'flowpq' in raster/r.terraflow/sweep.cpp

Co-authored-by: Shubham Vasudeo Desai <[email protected]>

Use parson to add json output format support to the r.profile module.

* Rename l to line when using `f.readlines()`.

* Remove "l"s from parameters since they aren't used.

* Rename "l" to "lx" to assign a lexer object.

* Add "# noqa: E741" as renaming parameters won't be applicable in this case.

* Rename "l" to "ln" as line number.

* Rename "l" to "layer" when looping through the layer list.

* Remove E741 for files in the 'locale', `python`, and `scripts` directory.

* Rename "ln" to "line_number".

* Add JSON support to r.univar

Use parson to add json output format support to the r.univar module.

* Apply suggestions from code review

---------

Co-authored-by: Nicklas Larsson <[email protected]>

* Add JSON support to v.univar

Use parson to add json output format support to the v.univar module.

* update percentile format

* rename test file

Reduce scope of minreg and maxreg variables in d.labels/main.c

Co-authored-by: Shubham Vasudeo Desai <[email protected]>

Reduce scope of 'bg_w' variable in d.legend.vect/draw.c

Co-authored-by: Shubham Vasudeo Desai <[email protected]>

Fix uninitialized variable 'encoding' in parser_interface.c

Co-authored-by: Shubham Vasudeo Desai <[email protected]>

* CI(ruff): Fix typo in ruff suggestions

* CI(ruff): Upload suggestions even if not all linting errors were fixed

* CI(ruff): Try suggesting more changes

* CI(ruff): Upload suggestions even if not all linting errors were fixed but do not run when cancelled

…grass.script as gs`) (#3981)

* style: Unignore unconventional-import-alias (ICN001) ruff rule

* style: Use convention `import matplotlib as mpl`

* style: Use convention `import numpy as np`

* style: Use convention `import grass.script as gs`

* test: Remove unused grass.script in test file

* style: Add missing alias to `import grass.script as gs`

* style: Alias `import grass.script as gs` when already imported at file-level

* Remove duplicated grass.script lazy import in wxpython/gui_core/ghelp.py

…3984)

…ft.c (#3973)

imagery: Fix uninitialized struct member 'ngbr_rc.next' in mean_shift.c

Co-authored-by: Shubham Vasudeo Desai <[email protected]>

Co-authored-by: Shubham Vasudeo Desai <[email protected]>

…3974)

* Fix uninitialized struct member error in region_growing.c

Co-authored-by: Shubham Vasudeo Desai <[email protected]>
Co-authored-by: Shubham Vasudeo Desai <[email protected]>

…p, dp_max, dm, and dm_max to 0.0 (#3995)

Fixed uninitialized variable warning in dmax.c by initializing dp, dp_max, dm, and dm_max to 0.0.

* temporal: Actually call dbif.close() to fix pylint pointless-statement (W0104)

* g.extension: Fix pylint pointless-statement (W0104)

* temporal: Fix pointless-statement (W0104) in temporal_granularity

* temporal: Fix pointless-statement (W0104) in c_libraries_interface.py, _read_vector_history() function

* i.atcorr: Remove useless and non-working print statements in create_iwave.py

* python(grass.imaging): Use PIL.__version__ call to fix pylint pointless-statement

* style: Ignore ruff useless-expression (B018) for a gunittest data file. Equivalent to pylint pointless-statement / W010

* style: Enable ruff useless-expression (B018) (equivalent to pylint pointless-statement / W010)

Using `ruff check --output-format=concise --preview --select UP022 --unsafe-fixes --fix`

…ue (SIM211) (#3999)

Relates to pylint rule simplifiable-if-expression / R1719

…3939)

* python(grass.temporal): Fix pylint try-except-raise (W0706)

Do not catch exception only to raise it again

* gui/wxpython/core/utils: Fix pylint try-except-raise (W0706)

* python: Fix pylint try-except-raise (W0706)

* style: Enable ruff useless-try-except (TRY302) as fixed

When iterating over a dictionary with dict.items() but discarding either the values or the keys, dict.values() or dict.keys() should be used instead

* style: Fix not-is-test (E714)

* style: Fix not-in-test (E713)

Fix uninitialized variable issue in o_var.c

Co-authored-by: Shubham Vasudeo Desai <[email protected]>

Co-authored-by: Shubham Vasudeo Desai <[email protected]>