Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename optimism to op-mainnet #422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: rename optimism to op-mainnet #422

wants to merge 1 commit into from

Conversation

MuhtasimTanmoy
Copy link

Closes #421

@MuhtasimTanmoy MuhtasimTanmoy mentioned this pull request Nov 2, 2024
Open
@ncitron
Copy link
Collaborator

ncitron commented Nov 2, 2024 •
edited
Loading

Let's update the operationsolarstorm endpoint as well for consistency. I'll make sure to add an alias to that url.

@MuhtasimTanmoy
Copy link
Author

Let's update the operationsolarstorm endpoint as well for consistency. I'll make sure to add an alias to that url.

@ncitron Sure.

Btw, I ran cargo test-all after replacing .env with Alchemy API Key before pushing.

Output:

running 4 tests
test get_balance ... FAILED
test get_transaction_receipt ... FAILED
test call ... FAILED
test get_transaction_by_hash ... FAILED

failures:

---- get_balance stdout ----
thread 'get_balance' panicked at tests/rpc_equivalence.rs:22:59:
called `Result::unwrap()` on an `Err` value: NotPresent

---- get_transaction_receipt stdout ----
thread 'get_transaction_receipt' panicked at tests/rpc_equivalence.rs:22:59:
called `Result::unwrap()` on an `Err` value: NotPresent

---- call stdout ----
thread 'call' panicked at tests/rpc_equivalence.rs:22:59:
called `Result::unwrap()` on an `Err` value: NotPresent
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- get_transaction_by_hash stdout ----
thread 'get_transaction_by_hash' panicked at tests/rpc_equivalence.rs:22:59:
called `Result::unwrap()` on an `Err` value: NotPresent


failures:
    call
    get_balance
    get_transaction_by_hash
    get_transaction_receipt

test result: FAILED. 0 passed; 4 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s

Is this something I should be concerned about?

@ncitron
Copy link
Collaborator

ncitron commented Nov 2, 2024

Yeah thats fine. Those env vars get injected by our CI which is why it fails locally.

@ncitron
Copy link
Collaborator

ncitron commented Nov 5, 2024

Did you push your commit to update the URLs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: rename optimism to op-mainnet
2 participants
@MuhtasimTanmoy @ncitron