fix(jolt-core): Fixes DIVU and REMU sequence_output #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We return the correct output from sequence output when the divisor is zero, for divu and remu.
|
From #498 I believe we just need to fix the sequence output (which is used in the jolt virtual sequence test macro) to be output uint::max when the divisor is zero. |
moodlezoup
reviewed
Nov 18, 2024
Comment on lines
209
to
217
| let quotient = if y == 0 { | ||
| match WORD_SIZE { | ||
| 32 => u32::MAX as u64, | ||
| 64 => u64::MAX, | ||
| _ => panic!("Unsupported WORD_SIZE: {}", WORD_SIZE), | ||
| } | ||
| } else { | ||
| x / y | ||
| }; |
There was a problem hiding this comment.
let's get rid of this and just move the existing match into the else block below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We return the correct output from sequence output when the divisor is zero, for divu and remu.
Should fix #499