Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompile Backend #562

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
9d21aa7
added precompile code for common directory
Roee-87 Jan 14, 2025
e7e56aa
added comments for jolt-core/jolt/instruction/ecall.rs
Roee-87 Jan 14, 2025
c2d1abb
added prcompile directory to jotl-core/jolt/
Roee-87 Jan 14, 2025
337af2a
added precompile template code to jolt-sdk
Roee-87 Jan 14, 2025
379541c
added skeleton code for ecall.rs
Roee-87 Jan 15, 2025
8b15c33
removed extra two virtual advice registers
Roee-87 Jan 15, 2025
ab4d42d
added prove and verify placeholder functions in jolt-sdk/macros/lib.rs
Roee-87 Jan 15, 2025
9d0231a
added skeleton code to tracer/src/emulator/cpu.rs
Roee-87 Jan 15, 2025
053d7f3
added set_precompile_output_word() to mmu.rs
Roee-87 Jan 16, 2025
da40ee3
updated mmu precompile methods
Roee-87 Jan 16, 2025
3f38bd5
updated cpu.rs
Roee-87 Jan 16, 2025
f65d5f3
added ok(()) to ecall method
Roee-87 Jan 16, 2025
e85ddbe
updated precompile mod.rs for jolt-core
Roee-87 Jan 16, 2025
691efe6
added 16 advice instruction to ecall.rs
Roee-87 Jan 16, 2025
b70ce3c
added 16 advice instructions to ecall.rs
Roee-87 Jan 16, 2025
8f06579
added conditional for precompile output to load method
Roee-87 Jan 16, 2025
e813eac
fixed typo
Roee-87 Jan 16, 2025
b3b57ae
unsure of how to handle store() method in rv_trace.rs
Roee-87 Jan 16, 2025
9499b18
refactored rv_trace.rs to include conditionals for precompiles in sto…
Roee-87 Jan 16, 2025
c972066
added correct address for panic mem region
Roee-87 Jan 16, 2025
fd62abf
updated jolt-sdk
Roee-87 Feb 6, 2025
952d96d
added comment
Roee-87 Feb 6, 2025
3600f9c
updated instructions for ecall and precompile
Roee-87 Feb 6, 2025
0c5466a
added precompile to list of RISCV32 enum
Roee-87 Feb 6, 2025
4748f73
updated rv_trace.rs to include code for setting precompile flag
Roee-87 Feb 6, 2025
9af1042
Merge branch 'a16z:main' into rr-jolt-precompile-backend
Roee-87 Feb 6, 2025
d562e2c
fixed typo for precompile_input(s)/output(s)
Roee-87 Feb 6, 2025
5334965
fixed ordering for RV32IM instructions in rv_tracer.rs
Roee-87 Feb 6, 2025
e264e85
added WORD_SIZE type to advice instruction for ecall.rs
Roee-87 Feb 6, 2025
d00f4da
added notes
Roee-87 Feb 15, 2025
1439ad1
updated to latest main
Roee-87 Feb 26, 2025
5407655
reverted changes to jolt-sdk
Roee-87 Feb 26, 2025
37da785
modified associated types for precompile trait
Roee-87 Feb 26, 2025
7c4ceaf
fixed formatting
Roee-87 Feb 26, 2025
0782e6e
set precompile input and output memory address using jolt_device.memo…
Roee-87 Feb 26, 2025
a8ef501
made precompile directory a moddule in jolt/common/
Roee-87 Feb 27, 2025
6b6f96e
modified precompile input/output methods for cpu.rs and mmu.rs
Roee-87 Feb 27, 2025
e26b960
code cleanup
Roee-87 Feb 27, 2025
86d90c7
fixed typos
Roee-87 Feb 27, 2025
93503d4
removed try_into() from bn254_add inputs
Roee-87 Feb 27, 2025
060e239
debug
Roee-87 Feb 27, 2025
344a9ca
hopefully last clippy complaint...
Roee-87 Feb 27, 2025
159b7e1
fixed clippy errors for mmu.rs and cpu.rs
Roee-87 Feb 27, 2025
450708c
updated ecall.rs
Roee-87 Feb 27, 2025
2e7c0f2
added sequence_output placeholder function to ecall.rs
Roee-87 Feb 28, 2025
5ad76d8
Merge branch 'main' of github.com:Roee-87/jolt into rr-jolt-precompil…
Roee-87 Feb 28, 2025
c528616
updated ecall.rs RVTraceRow fields
Roee-87 Feb 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
added correct address for panic mem region
Roee-87 committed Jan 16, 2025
commit c972066b3b2ee11059f16f300f456d2f47c28a4e
2 changes: 1 addition & 1 deletion common/src/rv_trace.rs
Original file line number Diff line number Diff line change
@@ -749,7 +749,7 @@ impl MemoryLayout {
let precompile_input_end = precompile_input_start + 16; // 512 bits
let precompile_output_start = precompile_input_end;
let precompile_output_end = precompile_output_start + 16; // 512 bits
let panic = output_end;
let panic = precompile_output_end;
let termination = panic + 4;

Self {