add translate text support for ios #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasmil
approved these changes
Mar 28, 2023
|
Let's try to merge this and test it if it works. It should not break anything else. |
a7medev
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Sorry for this taking so much time! I had comments already put but forgot to submit the review 😅 So sorry for the inconvenience, we only have two small comments regarding code.
I'll manually test it to make sure it's working fine and if so we can merge it ASAP 🙏🏼
| callback(@[[NSString stringWithFormat: @"numberArgument: %@ stringArgument: %@", numberArgument, stringArgument]]); | ||
| NSString *text = [optionsMap objectForKey:@"text"]; | ||
|
|
||
| NSLog(@" text = %@",text); |
Comment on lines
+28
to
+29
| NSLog(@" sourceLanguage = %@",sourceLanguage); | ||
| NSLog(@" targetLanguage = %@",targetLanguage); |
There was a problem hiding this comment.
Let's also remove these two logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.