Throws an error in JSLint and also in JSHint #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So some small repair, but I haven't tested, if the function will do the same as before...
|
A return statement in a while loop? |
|
Did you mean: if (node.specified) {
wrapper.setAttribute(node.nodeName, node.nodeValue));
} |
|
Oh, sorry, I didn't realize the surrounding while loop. And yes, I meant something like if clause or the ? : pattern, the return is not possible |
|
Concretely: On the line 362 throws JSHint the error "Expected an assignment or function call and instead saw an expression." I just tried to fix it, because the while loop should not contain only expressions, but it depends on the opinion. |
|
Closed in favor of #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So some small repair, but I haven't tested, if the function will do the same as before...