Some changes to help with minification #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
‘typeof foo == "undefined"’ is identical to ‘foo === void 0’ yet the latter is shorter so prefer it over the former.
Strictly speaking, ‘!foo’ is superset of ‘foo === void 0’, but in all of the cases it actually doesn’t matter and simple negation produces shorter code.
Creating an annonymous scope requires creation of a function which can only be done with a rather long ‘function’ keyword. This isn’t helping with minification so it’s better avoidid in possible. Wrapping try-catch blocks in a function helps with engine’s optimisation but HTML5 Shiv is hardly a piece of code which needs to be super-fast. Furthermore, browsers which don’t support HTML5 are likely to not benefit from the optimisation either. Get rid of the anonymous function.
document.createElement(a) is already called few statements above so if it was supposed to throw an exception, it wolud have already done that.
Some minifiers aren’t smart enough to notice they can safely inline a function call when supportsUnknownElements was checked so go ahead and do that for them.
mina86
force-pushed
the
master
branch
2 times, most recently
from
a273372
to
9ffc7aa
Compare
This helps some minifiers which aren’t smart enough to inline the function in the first place.
Make the code shorter by testing whether elements is a string or an arary by presence of a join method rather than using typeof.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.