Removed wait-for-mongo call to fix issues with deployment for Meteor 1.6 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
formspoint
approved these changes
Jul 2, 2018
|
This PR should be pushed to the mupc-1.6 branch |
|
Is there a 1.6 branch already or do I have to create it? I'm not too familiar with pull request processes. |
|
FWIW I just noticed this issue because you had a fork of my Filog repo, and I happen to have created a minimal-delay solution to the "wait for mongo" problem when deploying Meteor apps: https://github.com/fgm/untilmongod : you might be interested. |
|
Just create a new branch off of 1.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue comes from the wait-for-mongo call, it probably isn't compatible for use with Meteor 1.6