Added reference on e-json example for Dream.json #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantron
reviewed
Oct 30, 2024
src/dream.mli
Outdated
| {!Dream.application_json}. | ||
|
|
||
| See example | ||
| {{:https://github.com/aantron/dream/tree/master/example/e-json#e-json} |
There was a problem hiding this comment.
Can you please link to a permanent anchor like #files, as most of the other example links do? The anchor #e-json will become invalid if the example ever gets renamed, or even if we just adopt a different style of titling the examples without renaming or renmbering them.
There was a problem hiding this comment.
Done.
For unknown reason test on windows failed. Seems it's sporadic event that wasn't caused by these changes.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.