Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for selector list #16

Closed
wants to merge 1 commit into from

Conversation

Lyokovic
Copy link

Hi,

Here is the implementation of #15, thanks for your advice!
I was not sure if I should split the select function, it did not looked weird to me to leave it like that.

I quickly tested it with a simple selector and with a selector list and it seems to work as (I) expected.

@Lyokovic
Copy link
Author

Hah, maybe running the tests could help... Back to work :p

@aantron
Copy link
Owner

aantron commented Feb 12, 2018

Yes, thank you :)

I would recommend also adding new tests for the new functionality.

@aantron
Copy link
Owner

aantron commented Mar 1, 2018

@Lyokovic, it turns out some of the test failures were caused by an upstream change. I've adjusted to that in master (see d51e1c3). After rebasing on master, there are still some failures, that look related to the new code, but the test results are much less noisy.

@Lyokovic
Copy link
Author

Lyokovic commented Mar 2, 2018

I just pushed a fix of a quite obvious mistake. But there is still one more failure with my branch, I do not get what is wrong :/

I'll continue investigating and try to add some tests later.

@aantron
Copy link
Owner

aantron commented Mar 2, 2018

No problem, take your time. And let me know if you would like any form of assistance :)

@aantron aantron added this to the 0.6.4 milestone Aug 17, 2019
@aantron
Copy link
Owner

aantron commented Nov 7, 2021

Closing this PR as stale.

@aantron aantron closed this Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants