Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer review: <Promish Kandel Team 22> For all of the requirements their is no fit critrion or it isn't apparent #105

Open
Tracked by #66
PromishKandel opened this issue Oct 14, 2024 · 1 comment
Assignees
Labels
review To be used with different parties for review purposes

Comments

@PromishKandel
Copy link

artifact under review.

SRS Volere Template for TinyMorph Sections related to functional and nonfunction requirements

team number (for the team doing the review). Team 22

description of issue.

For most of the requirements (lets take 12.1 as an example) there is no fit criterion.
In 12.1 PR-SLR1 its written: TTFT should be minimum, around 200-500ms, you give a rationale for why you have this which is good. However, you also have to write how you know that specification is successful. Similar this is also the case for the one below. I would advise going to through all of the requirements and making it clear how you know when that requirement has been achieved.

@PromishKandel PromishKandel added the review To be used with different parties for review purposes label Oct 14, 2024
@aarnphm
Copy link
Owner

aarnphm commented Oct 16, 2024

Thanks for the review. For specific requirements, we will need to devise a benchmark setup to test these specific metrics.

We will update you accordingly. But I do think this doesn't apply to all requirements that don't have concrete metrics

@lucas-lizhiwei lucas-lizhiwei self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review To be used with different parties for review purposes
Projects
None yet
Development

No branches or pull requests

3 participants