-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix escaping in JSON schema patterns
The escaping logic for patterns in JSON schema got convoluted, and we introduced inadvertently inconcistencies in the formatting. Namely, we first *unescaped* all the characters before passing them into the parser for regular expressions. This unescaped characters later propagated and mixed with *escaped* characters when the expression was transpiled for UTF-16. To solve this mess, we remove the unescaping step at the beginning and test more thouroughly to specify & observe the expected behavior.
- Loading branch information
Showing
6 changed files
with
128 additions
and
79 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.