Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "@container": "@set" and fix URIs in JSON LD #420

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

Murloc6
Copy link
Contributor

@Murloc6 Murloc6 commented Nov 9, 2023

We specify "@container": "@set" when it is needed in JSON LD.

Additionally, we also patch a minor issue related to predicate URIs
inconsistent with other schemas.

Copy link
Contributor

@mristin mristin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Murloc6! There is a minor remark -- please finalize, and then the pull request can be merged in.

aas_core_codegen/jsonld/main.py Outdated Show resolved Hide resolved
@Murloc6 Murloc6 requested a review from mristin November 15, 2023 14:45
@Murloc6
Copy link
Contributor Author

Murloc6 commented Nov 16, 2023

@mristin The PR is still in state "needs changes" but I took into account your review. Can't see if I miss some reviews somewhere like last time ?

@mristin mristin changed the title fix: Add "@container": "@set" when it is needed and predicate URI generation Add "@container": "@set" and fix URIs in JSON LD Nov 19, 2023
@mristin mristin merged commit a7d9234 into aas-core-works:main Nov 19, 2023
4 checks passed
@mristin
Copy link
Contributor

mristin commented Nov 19, 2023

Thanks again, @Murloc6!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants