Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a wrapping @context tag to JSON-LD generator #454

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

ethieblin
Copy link
Contributor

@ethieblin ethieblin commented Mar 19, 2024

This PR is related to admin-shell-io/aas-specs#386.
It adds a wrapping "@context" tag around the JSON-LD context.
It is needed so that the context can be served directly at a given URL and digested in a JSON-LD document.

@mristin mristin changed the title feat(jsonld): add wrapping @context tag Add a wrapping @context tag to JSON-LD generator Mar 19, 2024
@mristin
Copy link
Contributor

mristin commented Mar 19, 2024

@VladimirAlexiev and/or @ethieblin Could you please explain a bit the reason behind this change so that I can write a proper description in the pull request? It doesn't have to be long, but just something that allows the future readers of the commit history to understand the background.

@mristin
Copy link
Contributor

mristin commented Mar 19, 2024

@ethieblin please also see the failing CI -- I think you need to re-format the code (by calling continuous_integration/precommit.py --overwrite).

This issue is related to admin-shell-io/aas-specs#386
It is needed so that the context can be served directly at a given URL
and digested in a JSON-LD document
@ethieblin
Copy link
Contributor Author

@mristin Is it ok for you now ?

@mristin mristin merged commit a35fd9a into aas-core-works:main Mar 20, 2024
8 checks passed
@mristin
Copy link
Contributor

mristin commented Mar 20, 2024

Thanks, @ethieblin, LGTM!

@VladimirAlexiev
Copy link

@mristin According to the JSON-LD spec, a remote context must be a valid JSON-LD document, which means that it needs to include the word @context at top level.

@mristin
Copy link
Contributor

mristin commented Mar 21, 2024

Thanks, @VladimirAlexiev ! I already merged in the pull request, but the readers can look up this discussion for further info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants