Rename of pascal case to snake case #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 4, 2024 08:20
…red modules `constants` and `structure`
|
@TomGneuss sorry, I forgot to mention. There are pre-commit checks in place: https://github.com/aas-core-works/aas-core-codegen/blob/main/CONTRIBUTING.rst#pre-commit-checks Can you please re-format the code and commit again? |
|
@mristin I ran the code-formatting script. However, the mypy part fails in (almost) all language generators and I cannot grasp where that problem originates from |
|
@TomGneuss I'll try to have a look at it tonight. |
|
Thanks, @TomGneuss ! I fixed the minor issues -- I think you forgot to rebase or propagate the renames in Git. I'd suggest you to rebase now the other pull request, #476. |
mristin
changed the title
mristin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #477 , the functions shall be renamed to use the correct nomenclature. The original authors of the code confused pascal case with snake case by mistake. The correct name should have been snake case.