Check explicitly for invalid model type in Python #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We explicitly check in the generated Python code that the concrete classes without descendants which have a ``modelType`` defined in the de-serialization for backwards compatibility also specify a valid and expected ``modelType`` in JSON de-serialization.
mristin
added a commit
that referenced
this pull request
Jul 19, 2024
Please see #510 for more details. This is a fix particularly for C# generation.
mristin
added a commit
that referenced
this pull request
Jul 19, 2024
Please see #510 for more details. This is a fix particularly for C# generation.
mristin
added a commit
that referenced
this pull request
Jul 20, 2024
Please see #510 for more details. This is a fix particularly for Go generation.
mristin
added a commit
that referenced
this pull request
Jul 20, 2024
Please see #510 for more details. This is a fix particularly for Go generation.
mristin
added a commit
that referenced
this pull request
Jul 22, 2024
Please see #510 for more details. This is a fix particularly for TypeScript generation.
mristin
added a commit
that referenced
this pull request
Jul 22, 2024
Please see #510 for more details. This is a fix particularly for TypeScript generation.
mristin
added a commit
that referenced
this pull request
Jul 22, 2024
Please see #510 for more details. This is a fix particularly for C++ generation.
mristin
added a commit
that referenced
this pull request
Jul 22, 2024
Please see #510 for more details. This is a fix particularly for C++ generation.
empwilli
added a commit
to empwilli/aas-core-codegen
that referenced
this pull request
Jul 23, 2024
Please see aas-core-works#510 for more details. This is a fix particularly for Java generation.
mristin
pushed a commit
that referenced
this pull request
Jul 23, 2024
Please see #510 for more details. This is a fix particularly for Java generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We explicitly check in the generated Python code that the concrete classes without descendants which have a
modelTypedefined in the de-serialization for backwards compatibility also specify a valid and expectedmodelTypein JSON de-serialization.