Use _choice suffix consistently in Protobuf
#534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red modules `constants` and `structure`
…ish two subclasses of the same interface
removed suffix "choice"
Remove blank
Remove empty lines and blanks
… gh-protobuf # Conflicts: # aas_core_codegen/protobuf/structure/_generate.py
The enum MessageType is unnecessary when generating ProtoBuf files. Its intended use for identifying the concrete message in a "oneof" is carried out by the protoc compiler when generating code.
# Conflicts: # aas_core_codegen/protobuf/structure/_generate.py
Add suffix "_choice" to all abstract or concrete types with >0 concrete subtypes
the comment regarding the _choice suffix in generate_type() has been updated
|
Apparently, commits from an old PR of mine are still included. Sorry for the mess. Only the latest 2 commits are relevant to this PR. Refer to the list of changed files to confirm this. |
added 2 commits
October 28, 2024 13:43
Adjust expected output of ProtoBuf generator to match the current version of aas-core-meta v3
mristin
changed the title
_choice suffix consistently in Protobuf
mristin
approved these changes
Oct 28, 2024
|
Thanks, @TomGneuss ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #531 the
_choicesuffix has been introduced for concrete types with concrete classes as subtypes. Since Protobuf does not support inheritance, this was necessary so that we can distinguish between the concrete class and a choice (union) class with quasi-polymorphism. For the sake of consistency, this suffix shall be used for all types that have concrete descendants, i.e. for all the choice (union) classes, including the abstract classes.