Return only abstract errors #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We returned concrete errors (such as `jsonization.DeserializationError`) instead of abstract `error`'s. This is a common footgun in Go, see [this page in Golang's documentation]. Instead, in this patch, we always return the abstract `error`'s. Fixes #28. [this page in Golang's documentation]: https://go.dev/doc/faq#nil_error
mristin
force-pushed
the
mristin/Return-abstract-errors-in-public-functions
branch
from
24b646b to
066d747
Compare
Closed
Merged
mristin
added a commit
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We returned concrete errors (such as
jsonization.DeserializationError) instead of abstracterror's. This is a common footgun in Go, see this page in Golang's documentation.Instead, in this patch, we always return the abstract
error's.Fixes #28.