Fix jsonization confusing dict for array
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mristin
force-pushed
the
mristin/Fix-jsonization-confusing-dict-for-iterable
branch
from
68df7ea to
eb1a1fa
Compare
We fix the JSON de-serialization so that it explicitly check that a property is an array-like value instead of simply checking for inheritance from ``collections.abc.Iterable``, as mappings are also iterables in Python. This corresponds to [aas-core-codegen bcab1a9c]. [aas-core-codegen bcab1a9c]: aas-core-works/aas-core-codegen@bcab1a9c Fixes #31.
mristin
force-pushed
the
mristin/Fix-jsonization-confusing-dict-for-iterable
branch
from
eb1a1fa to
2b1a543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fix the JSON de-serialization so that it explicitly check that a property is an array-like value instead of simply checking for inheritance from
collections.abc.Iterable, as mappings are also iterables in Python.This corresponds to aas-core-codegen bcab1a9c.
Fixes #31.