Check explicitly for missing model type #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add an explicit check for missing ``modelType`` to account for the case where a concrete class without descendants needs a model type for backwards compatibility even though the model type property is redundant. The code corresponds to [aas-core-codegen 84ccbb64], and the test data correspods to [aas-core3.0-testgen 1b00dbe45]. [aas-core-codegen 84ccbb64]: aas-core-works/aas-core-codegen@84ccbb64 [aas-core3.0-testgen 1b00dbe45]: aas-core-works/aas-core3.0-testgen@1b00dbe45 Fixes #32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add an explicit check for missing
modelTypeto account for the case where a concrete class without descendants needs a model type for backwards compatibility even though the model type property is redundant.The code corresponds to aas-core-codegen 84ccbb64, and the test data correspods to aas-core3.0-testgen 1b00dbe45.
Fixes #32.