Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What cause the issue
In line 94
YamlDotNet/YamlDotNet.Analyzers.StaticGenerator/TypeFactoryGenerator.cs
Lines 92 to 98 in b8ac2a9
When the StaticContext to be generated is in the global namespace,
syntaxReceiver.YamlStaticContextType?.GetNamespace()
returns an empty string instead of null. As a result, the??
operator does not take effect.So, the generated code in
YamlDotNetAutoGraph.g.cs
ends up as follows:Since there is no identifier following
namespace
, the compilation fails.About unit test case
Due to the stringent conditions required to trigger this issue, I am unsure how to write a unit test. Should I create a new console project to reproduce the issue?
A potential problem
When the auto-generated
StaticContext
is in the global namespace, other classes, such asStaticObjectFactory
, will also be created in the global namespace. This could potentially conflict with other classes.