-
Notifications
You must be signed in to change notification settings - Fork 8
feat: deployment script #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ccip-gho
Are you sure you want to change the base?
Conversation
DhairyaSethi
commented
Apr 24, 2025
•
edited
Loading
edited
- adds deployment script for UpgradeableBurnMintTokenPool, taking ccip deployments as a config input and validating the correct version of the dependencies (router, rmn proxy)
- upgrades native oppenzeppelin dependency to 5.1 from 4.9 to deploy the proxy contracts for this token pool, this is ok because:
- this dependency is used exclusively outside of the ccip contracts (which are not the focus on this fork, and are not used in any solidity integration tests)
- remap the previous dependency to gho-core's internal copy of openzeppelin contracts version 4.7
{ | ||
"42161": { | ||
"GHO_TOKEN": "0x7dfF72693f6A4149b17e7C6314655f6A9F7c8B33", | ||
"OWNER": "0xFF1137243698CaA18EE364Cc966CF0e02A4e6327", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth renaming to PROXY_ADMIN_OWNER
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rn also used as the owner the token pool, can decouple both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, better