fix: fix Horizon banner redirection when navigating from the sGHO page #2641
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.42 MB (🟡 +13 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Six Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
59.59 KB (🟡 +2 B) |
1.48 MB |
/markets |
33.63 KB (🟡 +3 B) |
1.46 MB |
/reserve-overview |
23.02 KB (🟡 +1 B) |
1.45 MB |
/safety-module |
37.02 KB (🟢 -4 B) |
1.46 MB |
/sgho |
79.05 KB (🟡 +85 B) |
1.5 MB |
/staking |
31.81 KB (-1 B) |
1.46 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
| console.log('Router path:', router.pathname); | ||
| // Automatically switch to mainnet if not already on mainnet when entering the sGHO page | ||
| // since sGHO only exists on Ethereum mainnet | ||
| // NOTE: Having currentMarket as a dependency in useEffect causes conflicts with the Horizon Banner interaction. |
There was a problem hiding this comment.
When we click the link in the banner to go to the Horizon Markets page, the useEffect detects that currentMarket has changed and re-renders the component, preventing us from reaching the desired page. The solution is to remove currentMarket from the useEffect dependency array.
pages/sgho.page.tsx
Outdated
|
|
||
| // Automatically switch to mainnet if not already on mainnet | ||
| const router = useRouter(); | ||
| console.log('Router path:', router.pathname); |
There was a problem hiding this comment.
lets remove comment before merge
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.42 MB (🟡 +13 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Six Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
59.59 KB (🟡 +2 B) |
1.48 MB |
/markets |
33.63 KB (🟡 +3 B) |
1.46 MB |
/reserve-overview |
23.02 KB (🟡 +1 B) |
1.45 MB |
/safety-module |
37.02 KB (🟢 -4 B) |
1.46 MB |
/sgho |
79.03 KB (🟡 +68 B) |
1.5 MB |
/staking |
31.81 KB (-1 B) |
1.46 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
General Changes
Developer Notes
currentMarketchange while we’re on the/sGhopage? This might be an edge case. I don’t think it’s possible.We can’t add
currentMarketto theuseEffectdependency array because it conflicts with the banner redirection.Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files