-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Math Magicians Full Website #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ab-noori
Your project is complete! There is nothing else to say other than... it's time to merge it
STATUS: APPROVED 🟢
Congratulations! 🎉
Highlight
🔆 The website has 3 pages: Home, Calculator, and Quote
🔆 For every page, there is a dedicated route to it made possible by React Router V6
🔆 Navigation links for all three routes are displayed on each page
- Check the inline comments under the review for sections to improve.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Whoistolu in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
@@ -84,7 +87,7 @@ | |||
## 🚀 Live Demo <a name="live-demo"></a> | |||
|
|||
> - [Live Demo on Gh-pages](https://ab-noori.github.io/math_magicians/) | |||
> - [Live Demo on Render](https://math-magicians-ab.onrender.com) | |||
> - [Live Demo on Render](https://math-magicians-fans.onrender.com) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [OPTIONAL] You have an awesome UI @ab-noori 🥇 However, kindly note that you have done a great job deploying this application to GitHub pages and on-render, however, you deleted the working URL for the on-render deployment and replaced it with the URL that is not working. Please replace with: https://math-magicians-ab.onrender.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Whoistolu 👋,
Thank you so much 🙏 for reviewing and approving my project.
Your nice and constructive feedback is appreciated 🙏 and I will consider that.
Math Magicians: full website
🌟Features:
🚀 Project Demo