fix: improve a promise all via parameter pack #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xWOF
previously approved these changes
Mar 18, 2025
0xWOF
force-pushed
the
feature/parameter_pack
branch
from
df0cd02 to
4dfc168
Compare
0xWOF
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Promise.allhas been improved using Swift 5.9 Parameter Packs. It can now handle any number of parameters without being limited by a fixed count.Previously,
Promise.allonly supported up to five promises and had a separate method for cases where the promise'sFailurewasNever. With Parameter Packs, these have been unified into a single method.When using
Promise.allwith parameters of type[Promise<Value, Failure>](when using an array), the existing code has been retained.Example