Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle stage messages #1501

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

flav-code
Copy link
Contributor

No description provided.

Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this small bold topic change text. Also will consult abal about that content reassignment since we're directly replacing data from discord.
otherwise LGTM

lib/structures/Message.js Outdated Show resolved Hide resolved
@bsian03
Copy link
Collaborator

bsian03 commented Jun 12, 2024

we decided the best way moving forward would be to remove all system localisation message handling, i.e. we will not be setting the message content if a particular message type required it

@flav-code
Copy link
Contributor Author

you want me to remove all data.content from message system ?

@bsian03
Copy link
Collaborator

bsian03 commented Jun 13, 2024

correct, the only thing that should be in content is what's reflected on discord

@MCausc78
Copy link

Personally I would make a getter like displayedContent or systemContent rather replacing data.content

@flav-code
Copy link
Contributor Author

Personally I would make a getter like displayedContent or systemContent rather replacing data.content

I agree

@bsian03
Copy link
Collaborator

bsian03 commented Jun 13, 2024

neither of us saw a legitimate and proper use case for having localised system messages in the message content. I'm happy for you to discuss this with me on discord though.

…h should remove the warning about unhandled message create
@flav-code
Copy link
Contributor Author

flav-code commented Jun 21, 2024

we could even do away with the user's call function, thus eliminating this unnecessary switching case

It would be nice to remove all functions not intended for bots from the lib, it would lighten the whole and remove unused code.

@bsian03
Copy link
Collaborator

bsian03 commented Jun 22, 2024

I'll work on that, the PR is massively out of date so I'll have to look over everything again but it's on my list of things to do asap, unless you're happy doing it of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants