-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle stage messages #1501
base: dev
Are you sure you want to change the base?
handle stage messages #1501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just this small bold topic change text. Also will consult abal about that content reassignment since we're directly replacing data from discord.
otherwise LGTM
accept the change Co-authored-by: bsian03 <[email protected]>
we decided the best way moving forward would be to remove all system localisation message handling, i.e. we will not be setting the message content if a particular message type required it |
you want me to remove all data.content from message system ? |
correct, the only thing that should be in content is what's reflected on discord |
Personally I would make a getter like |
I agree |
neither of us saw a legitimate and proper use case for having localised system messages in the message content. I'm happy for you to discuss this with me on discord though. |
…h should remove the warning about unhandled message create
we could even do away with the user's call function, thus eliminating this unnecessary switching case It would be nice to remove all functions not intended for bots from the lib, it would lighten the whole and remove unused code. |
I'll work on that, the PR is massively out of date so I'll have to look over everything again but it's on my list of things to do asap, unless you're happy doing it of course |
No description provided.