Replaced newest authors carousel with random ones

abartov · Nov 11, 2023 · 87c68d4 · 87c68d4
1 parent 7bd9893
commit 87c68d4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/app/controllers/welcome_controller.rb b/app/controllers/welcome_controller.rb
@@ -11,7 +11,8 @@ def index
     @pop_authors = popular_authors
     @pop_authors_this_month = @pop_authors # Temporary hack! TODO: stop cheating and actually count by month
     @pop_works = popular_works
-    @newest_authors = cached_newest_authors
+    # @newest_authors = cached_newest_authors # deprecated because we stopped producing portraits
+    @random_authors = Person.published.has_image.order(Arel.sql('RAND()')).limit(10)
     @newest_works = cached_newest_works
     @surprise_author = Person.where(id: Person.has_toc.pluck(:id).sample(1))[0]
     @surprise_work = randomize_works(1)[0]

diff --git a/app/views/shared/_authors.html.haml b/app/views/shared/_authors.html.haml
@@ -1,7 +1,7 @@
 - cache "homepage_authors", expires_in: 6.hours do
   .by-card-content-v02
     = render partial: 'shared/author_cards', locals: {title: t(:most_popular_authors), authors: popular_authors, surprise: false, id_frag: 'pop', skip_title: false, size: :large}
-    = render partial: 'shared/author_cards', locals: {title: t(:newest_authors), authors: newest_authors, surprise: true, id_frag: 'new', skip_title: false, size: :large}
+    = render partial: 'shared/author_cards', locals: {title: t(:random_authors), authors: random_authors, surprise: true, id_frag: 'new', skip_title: false, size: :large}
     .link-to-all-v02
       %a{style: 'font-weight:bold', href: authors_path}
         %span= t(:to_all_authors)

diff --git a/app/views/welcome/_homepage.html.haml b/app/views/welcome/_homepage.html.haml
@@ -9,7 +9,7 @@
           -#= t(:x_authors, x: @totals[:authors])
           = "(#{@totals[:authors]})"
         -# author carousels
-        = render partial: 'shared/authors', locals: {popular_authors: @pop_authors, random_authors: [], newest_authors: @newest_authors}
+        = render partial: 'shared/authors', locals: {popular_authors: @pop_authors, random_authors: @random_authors}
 
       -# most read and new works
       - cache "homepage_mostread", expires_in: 6.hours do

diff --git a/config/locales/he.yml b/config/locales/he.yml
@@ -299,8 +299,8 @@ he:
   whatsnew_subtitle: יצירות ויוצרים חדשים באתר, אירועים, סרטונים, וחדשות.
   whats_new: מה חדש בפרויקט
   project_ben_yehuda: פרויקט בן־יהודה
-  random_authors: יוצרים אקראיים
-  random_works: יצירות אקראיות
+  random_authors: יוצרים מן המאגר
+  random_works: יצירות מן המאגר
   featured_item: זרקור על יצירה
   edit_markdown: עריכת הטקסט
   edit_markdown_in_new_window: עריכת הטקסט בלשונית חדשה