Auto-populate pub details from publication

abartov · Jan 7, 2025 · a06866e · a06866e
1 parent a523c44
commit a06866e
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 10 deletions.
diff --git a/app/controllers/collections_migration_controller.rb b/app/controllers/collections_migration_controller.rb
@@ -10,7 +10,13 @@ def index
   def person
     @author = Authority.find(params[:id])
     @publications = @author.publications.no_volume.order(:title)
-    @pub_options = @publications.map { |pub| [pub.title, pub.id] }
+    @pub_options = []
+    pub_details = []
+    @publications.each do |pub|
+      @pub_options << [pub.title, pub.id]
+      pub_details << { id: pub.id, title: pub.title, year: pub.pub_year, publisher: pub.publisher_line }
+    end
+    @pub_details = pub_details.to_json
     @already_collected_ids = @author.collected_manifestation_ids
     # refresh uncollected works to reflect any changes we may have just made
     RefreshUncollectedWorksCollection.call(@author)

diff --git a/app/views/collections_migration/person.html.haml b/app/views/collections_migration/person.html.haml
@@ -53,11 +53,7 @@
 :javascript
   var already_collected_ids = [ #{@already_collected_ids.join(',')} ];
   $(document).ready(function() {
-    // decorate the legacy TOC with controls
-    // h3 tags are volume titles
-      // they may be links themselves, meaning single-text volumes
-    // p tags containing a tags are texts 
-    // p tags without a tags are publisher details or other metadata
+    var pub_details = JSON.parse('#{j(@pub_details)}');
 
     $('.toc h3').each(function(h) {
       $(this).append('&nbsp;&nbsp;&nbsp;<button class="make-volume">#{ t(".make_collection") }</button>');
@@ -75,29 +71,39 @@
       vol = $(this);
       nextuntil = vol.parent().nextUntil('h3');
       if(nextuntil.length > 0) {
-        guessed_pub_details = vol.parent().nextUntil('h3')[0].innerText;
+        guessed_pub_details = nextuntil[0].innerText;
         r = guessed_pub_details.lastIndexOf(',');
         if(r > 0) {
           second_part = guessed_pub_details.substring(r+1);
-          if(second_part.match(/\d+/) || second_part.match('"')) {
+          if(second_part.match(/\d+/) || second_part.match(/["”]/)) {
             guessed_publisher = guessed_pub_details.substring(0, r).trim();
             guessed_year = second_part.trim();
           } else {
             guessed_publisher = guessed_pub_details.trim();
             guessed_year = '';
           }
+        } else {
+          guessed_publisher = guessed_pub_details.trim();
+          guessed_year = '';
         }
       } else {
         guessed_publisher = '';
         guessed_year = '';
       }
-      $('<form>#{t("ingestible.volume_by_author")}<select id="publication"><option></option>#{options_for_select(@pub_options).gsub("\n","")}</select> <p/> #{t(:or)} #{t(:title)} <input id="pub_title" name="pub_title" style="background-color: #cccccc;"> <p />#{t(:collection_item_type)}<select id="ctype">#{options_for_select(collection_types_options).gsub("\n","")}</select> <p/>#{t(:in_role)}<select id="prole" style="z-index:10000">#{options_for_select(role_options).gsub("\n","")}</select><p/>#{t(".verify_publisher_line")}<input id="guessed_publisher" name="guessed_publisher" style="background-color: #cccccc; width:50%;">#{t(".year")}<input id="guessed_year" name="guessed_year" style="background-color: #cccccc; width: 150px;"></form>').dialog({
+      $('<form>#{t("ingestible.volume_by_author")}<select id="publication"><option></option>#{options_for_select(@pub_options).gsub("\n","")}</select> <p/> #{t(:or)} #{t(:title)} <input id="pub_title" name="pub_title" style="background-color: #cccccc;"> <p />#{t(:collection_item_type)}<select id="ctype">#{options_for_select(collection_types_options).gsub("\n","")}</select> <p/>#{t(:in_role)}<select id="prole" style="z-index:10000">#{options_for_select(role_options).gsub("\n","")}</select><p/>#{t(".verify_publisher_line")}: <p/>#{t(".city_and_publisher")}<input id="guessed_publisher" name="guessed_publisher" style="background-color: #cccccc; width:50%;">#{t(".year")}<input id="guessed_year" name="guessed_year" style="background-color: #cccccc; width: 150px;"></form>').dialog({
         modal: true,
         width: '100%',
         position: { my: 'top+15', at: 'top', of: window },
         open: function() {
           $('#guessed_publisher').val(guessed_publisher);
           $('#guessed_year').val(guessed_year);
+          $('#publication').on('change',function() {
+            idx = this.selectedIndex;
+            if(idx > 0) {
+              $('#guessed_publisher').val(pub_details[idx - 1].publisher);
+              $('#guessed_year').val(pub_details[idx - 1].year);
+            }
+          });
         },
         buttons: {
           'OK': function () {

diff --git a/config/locales/he.yml b/config/locales/he.yml
@@ -1449,7 +1449,7 @@ he:
       make_collection: צור כותר ושייך יצירות להלן
       mark_migrated: סיים הסבה והפעל את דף היוצר החדש ליוצר/ת זה/זו
       verify_publisher_line: פרטי הוצאה לאור – לתקן או למחוק אם שגוי!
-      city_and_publisher:
+      city_and_publisher: "עיר: מוציא לאור"
       year: שנת הוצאה לאור
     migrate:
       migrated_html: '<a href="%{link}" style="color:blue; text-decoration:underline; cursor:pointer;">דף היוצר החדש הופעל!</a>'