Pronto and Linters #314
Merged
Pronto and Linters #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damisul
force-pushed
the
linters
branch
5 times, most recently
from
ecada5e to
e3ee79a
Compare
… github action. Added intentional violation to trigger rubocop warning for test
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,3 +1,5 @@ | |||
| ruby '3.2.1' | |||
There was a problem hiding this comment.
Style/FrozenStringLiteralComment: Missing frozen string literal comment.
spec/api/v1/people_api_spec.rb
Outdated
| @@ -4,7 +4,7 @@ | |||
| include_context 'API Spec Helpers' | |||
|
|
|||
| describe 'GET api/v1/people/{id}' do | |||
| let(:detail) { 'metadata' } | |||
| let(:detail) { "metadata" } | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
abartov
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rubocop and haml_lint linters.
Configured GithubActions to use them via pronto.
Pronto is a tool which allows linter checks to be run only on diffs changed in given PR/commit. Without this rubocop (and other linters) would checked whole project every time.
NOTE: to build pronto we need additional development time dependency: 'cmake'.
Just use