Refactor works mobile filter #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…folder. Modified labels retrieval for checkboxes. Rewritten copyright filter in author browse page using checkbox_group partial. Added filter/languages partial for languages filter
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
damisul
force-pushed
the
refactor_works_mobile_filter
branch
from
08bddd4 to
0ad5884
Compare
damisul
force-pushed
the
refactor_works_mobile_filter
branch
2 times, most recently
from
e660f6b to
a930694
Compare
…ilter and moved this partial to shared/filters folder.
damisul
force-pushed
the
refactor_works_mobile_filter
branch
from
a930694 to
f9066f1
Compare
abartov
reviewed
Apr 23, 2024
| .by-card-v02.text-sorting#sort_filter_panel{style: 'display:show'} | ||
| = render partial: 'browse_filters' | ||
| .col-12.col-lg-8 | ||
| .by-card-v02.text-sorting#sort_filter_panel{ style: 'display:none' } |
There was a problem hiding this comment.
shouldn't this be conditional upon filters.empty? too?
There was a problem hiding this comment.
Thanks, @abartov a good catch!
But we cannot decide if element should be shown or not on server side, as we need to know if this is a mobile view or desktop.
So I've added JS code to handle this.
Also added couple of other adjustements:
- browse_intro snippet should not be shown on mobile at all (to copy old behaviour)
- added scrolling to the top of the list when mobile filter is applied.
And modified authors browse page accordingly.
…thors and mobile pages: they should not be shown on mobile at all. Added scrolling to the top of the list when mobile filter is applied.
abartov
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored works/browse page to use same html form for desktop and mobile views.
Refactored several partials to share more code between authors and works browse pages.