Refactor Person methods #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
damisul
force-pushed
the
person_methods_adjustements
branch
from
69b3e3c to
f7c6dd3
Compare
damisul
force-pushed
the
person_methods_adjustements
branch
from
f7c6dd3 to
0d32889
Compare
…ncluding unpublished, and refactored other methods in `Person` class to utilize it and `published_manifestations`. Added missing filtering by author role to some of the methods. Fixed some liter complaints.
damisul
force-pushed
the
person_methods_adjustements
branch
from
0d32889 to
43756cf
Compare
abartov
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup to comments in #345 (comment)
Updated method Person.published_manifestations, to accept several roles to filter.
Added method Person.manifestations with optional roles array as an argument to return all manifestations (including unpublished).
Updated several methods in Person to consider work as 'original' work only when person is listed as an author (previously it worked for any work-level involvements, e.g. illustrators) using
published_manifestationsandmanifestationsmethods.