Authors bugfixes #374
Merged
Authors bugfixes #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modified create_toc, to_manual_toc and destroy actions in authors_controller to use Authority instead of Person
- updated authors browse filter to properly filter by person's traits (period, gender, birth and death years)
damisul
commented
Jun 12, 2024
config/locales/he.yml
Outdated
| @@ -1109,6 +1109,7 @@ he: | |||
| no_such_item: אין פריט כזה. | |||
| item: פריט | |||
| created_toc: נוצר דף יוצר עם תבנית ריקה | |||
| already_has_toc: Author already has TOC | |||
There was a problem hiding this comment.
When I wrote spec for #to_manual_toc it turned out we miss this string
damisul
commented
Jun 12, 2024
| @@ -282,81 +282,63 @@ def by_tag | |||
| end | |||
|
|
|||
| def create_toc | |||
| author = Person.find(params[:id]) | |||
| unless author.nil? | |||
There was a problem hiding this comment.
Actually we have many places like this all over the code. They are useless, as ActiveRecord.find method raises an RecordNotFound exception if record with given id is not found. So we never get author.nil? condition satisfied, but code expects nil to be returned in such case.
abartov
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed several bugs introduced during Authorities refactoring:
P.S. also please see #373