Impressions and YearTotals update #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rence authorities instead of people
abartov
reviewed
Jun 14, 2024
There was a problem hiding this comment.
This seems to have slipped in by mistake.
There was a problem hiding this comment.
Hm... actually not. I want to merge this into a master branch and master branch should not know anything about ingestible table for now
There was a problem hiding this comment.
Oh, sorry! I instinctively misread the diff the other way around! :)
I am the one who mistakenly committed the ingestible. Sorry!
abartov
requested changes
Jun 14, 2024
abartov
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added migration to update impressions and year_totals records to reference authorities instead of people